-
Notifications
You must be signed in to change notification settings - Fork 4k
release-25.2: jobs: update status tables with delete then insert #147513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Previously, the auxillary job system tables were updated with an update stmt instead of a delete-then-insert approach to avoid an extra roundtrip to the kv layer. This optimization also included faulty error handling against a pk unique constraint violation. Specifically, these update paths would issue a delete if the internal executor returned an error on the update; however, the delete used the same txn as the original update, and the internal executor does not automatically clean up any uncommited data from the original update (i.e. via a savepoint rollback). To avoid further complicating this optimization by wrapping the update in a savepoint, this commit simply reverts the update path to the original delete then insert pattern. Epic: none Release note: none
4223a76 to
6a4e1fe
Compare
|
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
jeffswenson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Backport 1/1 commits from #147501 on behalf of @msbutler.
Previously, the auxillary job system tables were updated with an update stmt instead of a delete-then-insert approach to avoid an extra roundtrip to the kv layer. This optimization also included faulty error handling against a pk unique constraint violation. Specifically, these update paths would issue a delete if the internal executor returned an error on the update; however, the delete used the same txn as the original update, and the internal executor does not automatically clean up any uncommited data from the original update (i.e. via a savepoint rollback).
To avoid further complicating this optimization by wrapping the update in a savepoint, this commit simply reverts the update path to the original delete then insert pattern.
Epic: none
Release note: none
Release justification: