sql/faketreeeval: change DummyEvalPlanner errors to assertion failures#148250
Draft
michae2 wants to merge 1 commit intocockroachdb:masterfrom
Draft
sql/faketreeeval: change DummyEvalPlanner errors to assertion failures#148250michae2 wants to merge 1 commit intocockroachdb:masterfrom
michae2 wants to merge 1 commit intocockroachdb:masterfrom
Conversation
Calling any of these methods means that we're attempting some kind of scalar evaluation from DistSQL that should only happen on the gateway node. Change them to assertion failures to get better feedback. Epic: None Release note: None
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling any of these methods means that we're attempting some kind of scalar evaluation from DistSQL that should only happen on the gateway node. Change them to assertion failures to get better feedback.
Epic: None
Release note: None