kvcoord,kvserver: add a few more trace lines#150402
Open
stevendanna wants to merge 1 commit intocockroachdb:masterfrom
Open
kvcoord,kvserver: add a few more trace lines#150402stevendanna wants to merge 1 commit intocockroachdb:masterfrom
stevendanna wants to merge 1 commit intocockroachdb:masterfrom
Conversation
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
stevendanna
force-pushed
the
ssd/more-tracing-info
branch
2 times, most recently
from
83b51d2 to
69af6b5
Compare
stevendanna
force-pushed
the
ssd/more-tracing-info
branch
from
69af6b5 to
b02d464
Compare
This adds a few new trace events: - Make it clear whether a batch used async consensus or not. Currently, when reading a trace you have to just sort of know which log entries are missing when async consensus is used. - Log the batch that the kv client handed to the coord sender. This log line may be a bit redundant for SQL-initiated transactions, but it seems like it would be helpful when debugging KVNemesis. - Log the batch that DistSender is given. Often this can be substantively different than the user-provided batch since the transaction coordinator's interceptors can add, remove, or mutate requests. - Log sub-batches produced by ba.Split. I often forget this level of splitting even exists. Informs cockroachdb#150304 Release note: None
stevendanna
force-pushed
the
ssd/more-tracing-info
branch
from
b02d464 to
4285d90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a few new trace events:
Make it clear whether a batch used async consensus or not. Currently, when reading a trace you have to just sort of know which log entries are missing when async consensus is used.
Log the batch that the kv client handed to the coord sender. This log line may be a bit redundant for SQL-initiated transactions, but it seems like it would be helpful when debugging KVNemesis.
Log the batch that the coord sender is handing to distsender. This batch may be substantively different than the original batch that was handed to the coord sender.
Informs #150304
Release note: None