Skip to content

asim: update node capacity in updateStoreCapacity#150523

Draft
wenyihu6 wants to merge 1 commit intocockroachdb:masterfrom
wenyihu6:updatecapacity
Draft

asim: update node capacity in updateStoreCapacity#150523
wenyihu6 wants to merge 1 commit intocockroachdb:masterfrom
wenyihu6:updatecapacity

Conversation

@wenyihu6
Copy link
Copy Markdown
Contributor

This commit updates node capacity directly in updateStoreCapacity, which is called by StoreDescriptors - the component responsible for updating store capacity. This removes the need to populate the node capacity field before gossip and aligns the simulator more closely with the production code. Note that we update node capacity regardless of the useCached flag since this is also what the production code does.

Epic: none
Release note: none

This commit updates node capacity directly in updateStoreCapacity, which is
called by StoreDescriptors - the component responsible for updating store
capacity. This removes the need to populate the node capacity field before
gossip and aligns the simulator more closely with the production code. Note
that we update node capacity regardless of the useCached flag since this is
also what the production code does.

Epic: none
Release note: none
@blathers-crl
Copy link
Copy Markdown

blathers-crl Bot commented Jul 18, 2025

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants