asim: update node capacity in updateStoreCapacity#150523
Draft
wenyihu6 wants to merge 1 commit intocockroachdb:masterfrom
Draft
asim: update node capacity in updateStoreCapacity#150523wenyihu6 wants to merge 1 commit intocockroachdb:masterfrom
wenyihu6 wants to merge 1 commit intocockroachdb:masterfrom
Conversation
This commit updates node capacity directly in updateStoreCapacity, which is called by StoreDescriptors - the component responsible for updating store capacity. This removes the need to populate the node capacity field before gossip and aligns the simulator more closely with the production code. Note that we update node capacity regardless of the useCached flag since this is also what the production code does. Epic: none Release note: none
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates node capacity directly in updateStoreCapacity, which is called by StoreDescriptors - the component responsible for updating store capacity. This removes the need to populate the node capacity field before gossip and aligns the simulator more closely with the production code. Note that we update node capacity regardless of the useCached flag since this is also what the production code does.
Epic: none
Release note: none