Skip to content

sqlsmith: add label for loops and blocks#152032

Draft
ZhouXing19 wants to merge 2 commits intocockroachdb:masterfrom
ZhouXing19:label-plpgsql-smith
Draft

sqlsmith: add label for loops and blocks#152032
ZhouXing19 wants to merge 2 commits intocockroachdb:masterfrom
ZhouXing19:label-plpgsql-smith

Conversation

@ZhouXing19
Copy link
Copy Markdown
Collaborator

@ZhouXing19 ZhouXing19 commented Aug 18, 2025

Informs #106368

sqlsmith: add label for loops and blocks

So that the CONTINUE and EXIT stmt can specify the label for existing loop labels.

Release note: None


sqlsmith: add terminal stmt check for plpgsql

When the plpgsql statement sampler chooses one of {RETURN, EXIT, CONTINUE},
it should stop adding further statements to the same block. These statements
are terminal within their block, meaning any following statements would be
unreachable.

Release note: None

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@ZhouXing19 ZhouXing19 force-pushed the label-plpgsql-smith branch 2 times, most recently from 9dc3c9f to d458f62 Compare August 18, 2025 21:18
So that the CONTINUE and EXIT stmt can specify the label for existing
loop labels.

Release note: None
When the plpgsql statement sampler chooses one of {RETURN, EXIT, CONTINUE},
it should stop adding further statements to the same block. These statements
are terminal within their block, meaning any following statements would be
unreachable.

Release note: None
@ZhouXing19 ZhouXing19 force-pushed the label-plpgsql-smith branch from 0f3e48d to e245814 Compare August 19, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants