roachtest: add test selector logger#154392
Draft
williamchoe3 wants to merge 4 commits intocockroachdb:masterfrom
Draft
roachtest: add test selector logger#154392williamchoe3 wants to merge 4 commits intocockroachdb:masterfrom
williamchoe3 wants to merge 4 commits intocockroachdb:masterfrom
Conversation
Member
|
This change is |
williamchoe3
force-pushed
the
wchoe/add-logs-for-test-selector
branch
from
44c6d8e to
38d9b07
Compare
williamchoe3
force-pushed
the
wchoe/add-logs-for-test-selector
branch
from
6deb12f to
d92c846
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Putting this on hold for now. I feel like just adding the query doesn't really add all the insights i'd wanna see from test selection. I think the current selection model makes sense, I'd just like to at a glance more easily see what's going on.
Test selection is currently a black box. Adding logging to help see what's going on. i.e. test is timing out, we see that all tests got selected
In this case we know why, but it would be nice to see more details on selection for future issues