changefeedccl: fix blocking buffer memory metrics#154445
Open
asg0451 wants to merge 1 commit intocockroachdb:masterfrom
Open
changefeedccl: fix blocking buffer memory metrics#154445asg0451 wants to merge 1 commit intocockroachdb:masterfrom
asg0451 wants to merge 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
asg0451
force-pushed
the
fix-blocking-buffer-metrics
branch
from
a7b3cd7 to
7d4af7b
Compare
asg0451
requested review from
a team,
KeithCh and
rharding6373
and removed request for
a team and
rharding6373
asg0451
force-pushed
the
fix-blocking-buffer-metrics
branch
4 times, most recently
from
b7f08b9 to
debec41
Compare
Previously, we had separated blocking buffer metrics into one copy for each buffer. This was incorrect in the case of the memory accounting metrics, as we don't dealloc and realloc event memory when it's going from one buffer to the other. Fixes cockroachdb#147624 Release note (ops change): Removed misleading metrics: `changefeed.buffer_entries.allocated_mem.rangefeed`, `changefeed.buffer_entries.allocated_mem.aggregator`, `changefeed.buffer_entries_mem.acquired.rangefeed`, `changefeed.buffer_entries_mem.acquired.aggregator`, `changefeed.buffer_entries_mem.released.rangefeed`, `changefeed.buffer_entries_mem.released.aggregator`
asg0451
force-pushed
the
fix-blocking-buffer-metrics
branch
from
debec41 to
76c5a7d
Compare
Contributor
Author
|
the more i argue with the metrics system the more i want to just rip out the old versions and be done with it |
Contributor
|
I'll let you take care of that before I review 😬 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we had separated blocking buffer
metrics into one copy for each buffer. This was
incorrect in the case of the memory accounting
metrics, as we don't dealloc and realloc event
memory when it's going from one buffer to the
other.
Fixes #147624
Release note (ops change): Removed misleading
metrics:
changefeed.buffer_entries.allocated_mem.rangefeed,changefeed.buffer_entries.allocated_mem.aggregator,changefeed.buffer_entries_mem.acquired.rangefeed,changefeed.buffer_entries_mem.acquired.aggregator,changefeed.buffer_entries_mem.released.rangefeed,changefeed.buffer_entries_mem.released.aggregator