kvserver: don't allow cancellation of RemoveReplica call#155228
Draft
stevendanna wants to merge 1 commit intocockroachdb:masterfrom
Draft
kvserver: don't allow cancellation of RemoveReplica call#155228stevendanna wants to merge 1 commit intocockroachdb:masterfrom
stevendanna wants to merge 1 commit intocockroachdb:masterfrom
Conversation
It appears we can get a cancellation from Pebble during RemoveReplica. We've seen this before in cockroachdb#155121. Here, we construct a context that can't be cancelled. TODO: Should we push this down into RemoveReplica, can we ever handle RemoveReplica failing? TODO: Is there anywhere else that might be impacted by pebble being able to error from context cancellation. Informs cockroachdb#140958 Fixes cockroachdb#155121 Release note: None
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears we can get a cancellation from Pebble during RemoveReplica. We've seen this before in #155121. Here, we construct a context that can't be cancelled.
TODO: Should we push this down into RemoveReplica, can we ever handle RemoveReplica failing?
TODO: Is there anywhere else that might be impacted by pebble being able to error from context cancellation.
Informs #140958
Fixes #155121
Release note: None