Skip to content

Conversation

@mw5h
Copy link
Contributor

@mw5h mw5h commented Oct 16, 2025

While vector indexing was in tech preview, it was disabled by default. Now that we are transitioning this feature to general availability, it needs to be enabled by default.

Epic: CRDB-52151
Release note (sql change): Vector indexing is now enabled by default.

@mw5h mw5h requested a review from a team as a code owner October 16, 2025 18:38
@mw5h mw5h added the backport-25.4.x Flags PRs that need to be backported to 25.4 label Oct 16, 2025
@mw5h mw5h requested review from rytaft and removed request for a team October 16, 2025 18:38
@blathers-crl
Copy link

blathers-crl bot commented Oct 16, 2025

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@rytaft rytaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: 🎉

@rytaft reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @mw5h)

Copy link
Collaborator

@michae2 michae2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Exciting!

@michae2 reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 2 of 0 LGTMs obtained (waiting on @mw5h)

@mw5h mw5h requested a review from a team as a code owner October 16, 2025 21:27
@mw5h mw5h force-pushed the vecindex-enable branch 2 times, most recently from 1b35745 to 3120662 Compare October 16, 2025 22:22
While vector indexing was in tech preview, it was disabled by default.
Now that we are transitioning this feature to general availability, it
needs to be enabled by default.

Epic: CRDB-52151
Release note (sql change): Vector indexing is now enabled by default.
@mw5h
Copy link
Contributor Author

mw5h commented Oct 16, 2025

bors r+

@mw5h
Copy link
Contributor Author

mw5h commented Oct 16, 2025

TFTR!

@craig
Copy link
Contributor

craig bot commented Oct 17, 2025

@craig craig bot merged commit 81fd236 into cockroachdb:master Oct 17, 2025
31 of 33 checks passed
@blathers-crl
Copy link

blathers-crl bot commented Oct 17, 2025

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


💡 Consider backporting to the fork repo instead of the main repo. See instructions for more details.

error creating merge commit from 11f6cdd to blathers/backport-release-25.4-155536: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 25.4.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

rishabh7m added a commit to crltest-issue-syncing/cockroach-fork that referenced this pull request Nov 20, 2025
rishabh7m added a commit to crltest-issue-syncing/cockroach-fork that referenced this pull request Nov 21, 2025
rishabh7m added a commit to crltest-issue-syncing/cockroach-fork that referenced this pull request Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-25.4.x Flags PRs that need to be backported to 25.4 backport-failed target-release-26.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants