Skip to content

vecindex: enable vector indexing by default #155536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2025
Merged

vecindex: enable vector indexing by default #155536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/generated/settings/settings-for-tenants.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ feature.infer_rbr_region_col_using_constraint.enabled boolean false set to true
feature.restore.enabled boolean true set to true to enable restore, false to disable; default is true application
feature.schema_change.enabled boolean true set to true to enable schema changes, false to disable; default is true application
feature.stats.enabled boolean true set to true to enable CREATE STATISTICS/ANALYZE, false to disable; default is true application
feature.vector_index.enabled boolean false set to true to enable vector indexes, false to disable; default is false application
feature.vector_index.enabled boolean true set to true to enable vector indexes, false to disable; default is true application
jobs.retention_time duration 336h0m0s the amount of time for which records for completed jobs are retained application
kv.bulk_sst.target_size byte size 16 MiB target size for SSTs emitted from export requests; export requests (i.e. BACKUP) may buffer up to the sum of kv.bulk_sst.target_size and kv.bulk_sst.max_allowed_overage in memory system-visible
kv.closed_timestamp.follower_reads.enabled (alias: kv.closed_timestamp.follower_reads_enabled) boolean true allow (all) replicas to serve consistent historical reads based on closed timestamp information system-visible
Expand Down
2 changes: 1 addition & 1 deletion docs/generated/settings/settings.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
<tr><td><div id="setting-feature-restore-enabled" class="anchored"><code>feature.restore.enabled</code></div></td><td>boolean</td><td><code>true</code></td><td>set to true to enable restore, false to disable; default is true</td><td>Basic/Standard/Advanced/Self-Hosted</td></tr>
<tr><td><div id="setting-feature-schema-change-enabled" class="anchored"><code>feature.schema_change.enabled</code></div></td><td>boolean</td><td><code>true</code></td><td>set to true to enable schema changes, false to disable; default is true</td><td>Basic/Standard/Advanced/Self-Hosted</td></tr>
<tr><td><div id="setting-feature-stats-enabled" class="anchored"><code>feature.stats.enabled</code></div></td><td>boolean</td><td><code>true</code></td><td>set to true to enable CREATE STATISTICS/ANALYZE, false to disable; default is true</td><td>Basic/Standard/Advanced/Self-Hosted</td></tr>
<tr><td><div id="setting-feature-vector-index-enabled" class="anchored"><code>feature.vector_index.enabled</code></div></td><td>boolean</td><td><code>false</code></td><td>set to true to enable vector indexes, false to disable; default is false</td><td>Basic/Standard/Advanced/Self-Hosted</td></tr>
<tr><td><div id="setting-feature-vector-index-enabled" class="anchored"><code>feature.vector_index.enabled</code></div></td><td>boolean</td><td><code>true</code></td><td>set to true to enable vector indexes, false to disable; default is true</td><td>Basic/Standard/Advanced/Self-Hosted</td></tr>
<tr><td><div id="setting-jobs-retention-time" class="anchored"><code>jobs.retention_time</code></div></td><td>duration</td><td><code>336h0m0s</code></td><td>the amount of time for which records for completed jobs are retained</td><td>Basic/Standard/Advanced/Self-Hosted</td></tr>
<tr><td><div id="setting-kv-allocator-lease-rebalance-threshold" class="anchored"><code>kv.allocator.lease_rebalance_threshold</code></div></td><td>float</td><td><code>0.05</code></td><td>minimum fraction away from the mean a store&#39;s lease count can be before it is considered for lease-transfers</td><td>Advanced/Self-Hosted</td></tr>
<tr><td><div id="setting-kv-allocator-load-based-lease-rebalancing-enabled" class="anchored"><code>kv.allocator.load_based_lease_rebalancing.enabled</code></div></td><td>boolean</td><td><code>true</code></td><td>set to enable rebalancing of range leases based on load and latency</td><td>Advanced/Self-Hosted</td></tr>
Expand Down
15 changes: 0 additions & 15 deletions pkg/sql/backfill/backfill_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,6 @@ func TestVectorColumnAndIndexBackfill(t *testing.T) {
defer srv.Stopper().Stop(ctx)
sqlDB := sqlutils.MakeSQLRunner(db)

// Enable vector indexes.
sqlDB.Exec(t, `SET CLUSTER SETTING feature.vector_index.enabled = true`)

// Create a table with a vector column
sqlDB.Exec(t, `
CREATE TABLE vectors (
Expand Down Expand Up @@ -119,9 +116,6 @@ func TestConcurrentOperationsDuringVectorIndexCreation(t *testing.T) {
defer srv.Stopper().Stop(ctx)
sqlDB := sqlutils.MakeSQLRunner(db)

// Enable vector indexes.
sqlDB.Exec(t, `SET CLUSTER SETTING feature.vector_index.enabled = true`)

// Create a table with a vector column
sqlDB.Exec(t, `
CREATE TABLE vectors (
Expand Down Expand Up @@ -204,9 +198,6 @@ func TestVectorIndexWithPrefixBackfill(t *testing.T) {
defer srv.Stopper().Stop(ctx)
sqlDB := sqlutils.MakeSQLRunner(db)

// Enable vector indexes.
sqlDB.Exec(t, `SET CLUSTER SETTING feature.vector_index.enabled = true`)

// Create a table with a vector column + a prefix column.
sqlDB.Exec(t, `
CREATE TABLE items (
Expand Down Expand Up @@ -276,9 +267,6 @@ func TestVectorIndexMergingDuringBackfill(t *testing.T) {
defer srv.Stopper().Stop(ctx)
sqlDB := sqlutils.MakeSQLRunner(db)

// Enable vector indexes.
sqlDB.Exec(t, `SET CLUSTER SETTING feature.vector_index.enabled = true`)

// Enable deterministic vector index fixups for consistent testing.
sqlDB.Exec(t, `SET CLUSTER SETTING sql.vecindex.deterministic_fixups.enabled = true`)

Expand Down Expand Up @@ -373,9 +361,6 @@ func TestVectorIndexMergingDuringBackfillWithPrefix(t *testing.T) {
defer srv.Stopper().Stop(ctx)
sqlDB := sqlutils.MakeSQLRunner(db)

// Enable vector indexes.
sqlDB.Exec(t, `SET CLUSTER SETTING feature.vector_index.enabled = true`)

// Enable deterministic vector index fixups for consistent testing.
sqlDB.Exec(t, `SET CLUSTER SETTING sql.vecindex.deterministic_fixups.enabled = true`)

Expand Down
3 changes: 0 additions & 3 deletions pkg/sql/catalog/tabledesc/index_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,6 @@ func TestIndexInterface(t *testing.T) {
}
runner := sqlutils.MakeSQLRunner(conn)

// Enable vector indexes.
runner.Exec(t, `SET CLUSTER SETTING feature.vector_index.enabled = true`)

runner.Exec(t, `
CREATE TABLE d.t (
c1 INT,
Expand Down
8 changes: 0 additions & 8 deletions pkg/sql/logictest/logic.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1881,14 +1881,6 @@ func (t *logicTest) newCluster(
}
}

// Enable vector indexes by default for tests.
// TODO(andyk): Remove this once vector indexes are enabled by default.
if _, err := conn.Exec(
"SET CLUSTER SETTING feature.vector_index.enabled = true",
); err != nil {
t.Fatal(err)
}

// Ensure that vector index background operations are deterministic, so
// that tests don't flake.
if _, err := conn.Exec(
Expand Down
2 changes: 0 additions & 2 deletions pkg/sql/logictest/testdata/logic_test/event_log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,6 @@ ORDER BY "timestamp", info
----
1 {"ApplicationName": "$ internal-optInToDiagnosticsStatReporting", "DefaultValue": "true", "EventType": "set_cluster_setting", "SettingName": "diagnostics.reporting.enabled", "Statement": "SET CLUSTER SETTING \"diagnostics.reporting.enabled\" = true", "Tag": "SET CLUSTER SETTING", "User": "node", "Value": "true"}
1 {"DefaultValue": "-10s", "EventType": "set_cluster_setting", "SettingName": "sql.crdb_internal.table_row_statistics.as_of_time", "Statement": "SET CLUSTER SETTING \"sql.crdb_internal.table_row_statistics.as_of_time\" = e'-1\\u00B5s'", "Tag": "SET CLUSTER SETTING", "User": "root", "Value": "-00:00:00.000001"}
1 {"DefaultValue": "false", "EventType": "set_cluster_setting", "SettingName": "feature.vector_index.enabled", "Statement": "SET CLUSTER SETTING \"feature.vector_index.enabled\" = true", "Tag": "SET CLUSTER SETTING", "User": "root", "Value": "true"}
1 {"DefaultValue": "false", "EventType": "set_cluster_setting", "SettingName": "sql.vecindex.deterministic_fixups.enabled", "Statement": "SET CLUSTER SETTING \"sql.vecindex.deterministic_fixups.enabled\" = true", "Tag": "SET CLUSTER SETTING", "User": "root", "Value": "true"}
1 {"DefaultValue": "true", "EventType": "set_cluster_setting", "SettingName": "kv.allocator.load_based_lease_rebalancing.enabled", "Statement": "SET CLUSTER SETTING \"kv.allocator.load_based_lease_rebalancing.enabled\" = false", "Tag": "SET CLUSTER SETTING", "User": "root", "Value": "false"}
1 {"DefaultValue": "true", "EventType": "set_cluster_setting", "SettingName": "kv.allocator.load_based_lease_rebalancing.enabled", "Statement": "SET CLUSTER SETTING \"kv.allocator.load_based_lease_rebalancing.enabled\" = DEFAULT", "Tag": "SET CLUSTER SETTING", "User": "root", "Value": "DEFAULT"}
Expand All @@ -513,7 +512,6 @@ ORDER BY "timestamp", info
----
1 {"ApplicationName": "$ internal-optInToDiagnosticsStatReporting", "DefaultValue": "true", "EventType": "set_cluster_setting", "SettingName": "diagnostics.reporting.enabled", "Statement": "SET CLUSTER SETTING \"diagnostics.reporting.enabled\" = true", "Tag": "SET CLUSTER SETTING", "User": "node", "Value": "true"}
1 {"DefaultValue": "-10s", "EventType": "set_cluster_setting", "SettingName": "sql.crdb_internal.table_row_statistics.as_of_time", "Statement": "SET CLUSTER SETTING \"sql.crdb_internal.table_row_statistics.as_of_time\" = e'-1\\u00B5s'", "Tag": "SET CLUSTER SETTING", "User": "root", "Value": "-00:00:00.000001"}
1 {"DefaultValue": "false", "EventType": "set_cluster_setting", "SettingName": "feature.vector_index.enabled", "Statement": "SET CLUSTER SETTING \"feature.vector_index.enabled\" = true", "Tag": "SET CLUSTER SETTING", "User": "root", "Value": "true"}
1 {"DefaultValue": "false", "EventType": "set_cluster_setting", "SettingName": "sql.vecindex.deterministic_fixups.enabled", "Statement": "SET CLUSTER SETTING \"sql.vecindex.deterministic_fixups.enabled\" = true", "Tag": "SET CLUSTER SETTING", "User": "root", "Value": "true"}
1 {"EventType": "set_cluster_setting", "PlaceholderValues": ["'some string'"], "SettingName": "cluster.label", "Statement": "SET CLUSTER SETTING \"cluster.label\" = $1", "Tag": "SET CLUSTER SETTING", "User": "root", "Value": "'some string'"}

Expand Down
4 changes: 0 additions & 4 deletions pkg/sql/logictest/testdata/logic_test/system
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,6 @@ ORDER BY name
----
cluster.secret
diagnostics.reporting.enabled
feature.vector_index.enabled
sql.crdb_internal.table_row_statistics.as_of_time
sql.vecindex.deterministic_fixups.enabled
version
Expand All @@ -332,7 +331,6 @@ ORDER BY name
----
cluster.secret
diagnostics.reporting.enabled
feature.vector_index.enabled
sql.crdb_internal.table_row_statistics.as_of_time
sql.vecindex.deterministic_fixups.enabled
version
Expand All @@ -355,7 +353,6 @@ AND name NOT IN ('version', 'cluster.secret', 'kv.range_merge.queue_enabled')
ORDER BY name
----
diagnostics.reporting.enabled true
feature.vector_index.enabled true
somesetting somevalue
sql.crdb_internal.table_row_statistics.as_of_time -1µs
sql.vecindex.deterministic_fixups.enabled true
Expand All @@ -373,7 +370,6 @@ AND name NOT IN ('version', 'cluster.secret')
ORDER BY name
----
diagnostics.reporting.enabled true
feature.vector_index.enabled true
somesetting somevalue
sql.crdb_internal.table_row_statistics.as_of_time -1µs
sql.vecindex.deterministic_fixups.enabled true
Expand Down
Loading