rac2: add in-flight token counter for send tokens#156289
Open
sumeerbhola wants to merge 1 commit intocockroachdb:masterfrom
Open
rac2: add in-flight token counter for send tokens#156289sumeerbhola wants to merge 1 commit intocockroachdb:masterfrom
sumeerbhola wants to merge 1 commit intocockroachdb:masterfrom
Conversation
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
sumeerbhola
force-pushed
the
inflight_tokens
branch
from
dd31a0d to
20440ab
Compare
sumeerbhola
requested review from
shailendra-patel and
williamchoe3
and removed request for
a team
Contributor
Potential Bug(s) DetectedThe three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation. Next Steps: After you review the findings, please tag the issue as follows:
|
github-actions
Bot
added
the
o-AI-Review-Potential-Issue-Detected
This change is completely mechanical, with the core in the rac2 files: token_counter.go, store_stream.go, metrics.go. The inflight tokens are unused at the moment -- a future PR will use them in rangeController. Informs cockroachdb#155183 Epic: none Release note: None
sumeerbhola
force-pushed
the
inflight_tokens
branch
from
20440ab to
72a16e5
Compare
sumeerbhola
added
O-AI-Review-Real-Issue-Found
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is completely mechanical, with the core in the rac2 files: token_counter.go, store_stream.go, metrics.go. The inflight tokens are unused at the moment -- a future PR will use them in rangeController.
Informs #155183
Epic: none
Release note: None