kvserver: deflake TestFlowControlSendQueueRangeFeed #156616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
tbg
force-pushed
the
TestFlowControlSendQueueRangeFeed
branch
from
4ac0cbe to
4c72494
Compare
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
bot
added
the
o-AI-Review-Potential-Issue-Detected
This comment was marked as resolved.
This comment was marked as resolved.
The recently added logging showed that n2 and n3 just weren't even considered for starting the rangefeed. Likely this was because the descriptors weren't gossiped yet (this was corroborated by gossip logging). Rather than waiting for specific preconditions that "likely" fix the problem for the particular version of the code, widen the scope of the retry loop to re-establish the rangefeed until it does get scheduled were it needs to for the test to succeed. Epic: none
tbg
force-pushed
the
TestFlowControlSendQueueRangeFeed
branch
from
4c72494 to
cf1382a
Compare
|
TFTR! bors r+ |
|
blathers backport 25.4 25.3 25.2 25.1 |
|
Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches. Issue #156341: branch-release-25.1, branch-release-25.2, branch-release-25.3, branch-release-25.4. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This was referenced Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recently added logging showed that n2 and n3 just weren't even considered
for starting the rangefeed. Likely this was because the descriptors weren't
gossiped yet (this was corroborated by gossip logging).
Rather than waiting for specific preconditions that "likely" fix
the problem for the particular version of the code, widen the scope
of the retry loop to re-establish the rangefeed until it does get
scheduled were it needs to for the test to succeed.
Closes #156341.
Epic: none