Skip to content

Conversation

@andyyang890
Copy link
Collaborator

This patch deflakes cdc/ledger by increasing the target steady latency
from 1 minute to 3 minutes. It also eliminates a weird quirk where the
latency verifier expects the latency to be less than half of the target
latency before it'll be considered steady, which led to weird logs and
added unnecessary complexity.

Fixes #151381

Release note: None

This patch deflakes `cdc/ledger` by increasing the target steady latency
from 1 minute to 3 minutes. It also eliminates a weird quirk where the
latency verifier expects the latency to be less than half of the target
latency before it'll be considered steady, which led to weird logs and
added unnecessary complexity.

Release note: None
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@andyyang890 andyyang890 added the backport-all Flags PRs that need to be backported to all supported release branches label Nov 6, 2025
@andyyang890
Copy link
Collaborator Author

@andyyang890 andyyang890 marked this pull request as ready for review November 6, 2025 11:26
@andyyang890 andyyang890 requested review from a team and log-head November 6, 2025 11:26
Copy link
Contributor

@log-head log-head left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andyyang890 andyyang890 requested a review from asg0451 November 6, 2025 18:10
@andyyang890
Copy link
Collaborator Author

TFTRs!

bors r=log-head,asg0451

@craig
Copy link
Contributor

craig bot commented Nov 6, 2025

@craig craig bot merged commit 82eca8e into cockroachdb:master Nov 6, 2025
24 checks passed
@blathers-crl
Copy link

blathers-crl bot commented Nov 6, 2025

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


💡 Consider backporting to the fork repo instead of the main repo. See instructions for more details.

💡 Consider backporting to the fork repo instead of the main repo. See instructions for more details.

error creating merge commit from 08ce8f9 to blathers/backport-release-25.2-156985: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch release-25.2 failed. See errors above.


💡 Consider backporting to the fork repo instead of the main repo. See instructions for more details.

error creating merge commit from 08ce8f9 to blathers/backport-release-25.3-156985: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch release-25.3 failed. See errors above.


💡 Consider backporting to the fork repo instead of the main repo. See instructions for more details.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@andyyang890 andyyang890 deleted the 20251105-deflake-cdc-ledger branch November 6, 2025 22:18
@andyyang890
Copy link
Collaborator Author

Not seeing a merge conflict so I'll re-attempt with blathers

blathers backport 25.2 25.3

@blathers-crl
Copy link

blathers-crl bot commented Nov 7, 2025

Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches.


Issue #151381: branch-release-25.2, branch-release-25.3.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-all Flags PRs that need to be backported to all supported release branches target-release-26.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

roachtest: cdc/ledger failed

4 participants