Skip to content

Conversation

@blathers-crl
Copy link

@blathers-crl blathers-crl bot commented Nov 7, 2025

Backport 1/1 commits from #156985 on behalf of @andyyang890.


This patch deflakes cdc/ledger by increasing the target steady latency
from 1 minute to 3 minutes. It also eliminates a weird quirk where the
latency verifier expects the latency to be less than half of the target
latency before it'll be considered steady, which led to weird logs and
added unnecessary complexity.

Fixes #151381

Release note: None


Release justification: test-only change

This patch deflakes `cdc/ledger` by increasing the target steady latency
from 1 minute to 3 minutes. It also eliminates a weird quirk where the
latency verifier expects the latency to be less than half of the target
latency before it'll be considered steady, which led to weird logs and
added unnecessary complexity.

Release note: None
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-25.2-156985 branch from 26437d8 to 2fc68c0 Compare November 7, 2025 12:52
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Nov 7, 2025
@blathers-crl blathers-crl bot requested review from asg0451 and log-head November 7, 2025 12:52
@blathers-crl
Copy link
Author

blathers-crl bot commented Nov 7, 2025

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes. Includes test-only changes, build system changes, etc.
  • Fixes for serious issues. Defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to.

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl bot added backport Label PR's that are backports to older release branches T-cdc labels Nov 7, 2025
@blathers-crl
Copy link
Author

blathers-crl bot commented Nov 7, 2025

✅ PR #157057 is compliant with backport policy

Confidence: high
Backward compatible: true
Explanation: This pull request modifies test files within the 'pkg/cmd/roachtest/' directory, which are designated as non-production files according to the CockroachDB Backport Policy. The modifications in this PR adjust the test parameters and logic to improve the stability and reliability of the cdc/ledger test by adjusting its latency expectations. The 'Release justification: test-only change' directly stated in the PR body aligns with the policy exceptions for test-only changes, confirming that the PR need not meet the critical bug or feature flag requirements typically necessary for backporting. As only non-production files are affected, the change does not impact production database capabilities, system performance, or stability and thus remains backward compatible.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@blathers-crl blathers-crl bot added the backport-test-only Used to denote the backport has only non-production changes label Nov 7, 2025
@andyyang890 andyyang890 merged commit 87cf8e4 into release-25.2 Nov 7, 2025
16 checks passed
@andyyang890 andyyang890 deleted the blathers/backport-release-25.2-156985 branch November 7, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches backport-test-only Used to denote the backport has only non-production changes blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. T-cdc target-release-25.2.10

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants