sql: remove gossip-based DistSQL physical planning #157077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 25.1 release we switched to using SQL-instance-based DistSQL physical planning but left gossip-based planning just in case (controlled via a cluster setting). We haven't seen any fallout from that, and given that many different workloads have been upgraded to 25.2, it seems safe to completely remove gossip-based planning now. Release note: None
Member
|
This change is |
yuzefovich
requested review from
kev-cao
and removed request for
a team and
kev-cao
mgartner
approved these changes
Nov 7, 2025
Collaborator
mgartner
left a comment
mgartner
left a comment
There was a problem hiding this comment.
@mgartner reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball and @michae2)
michae2
approved these changes
Nov 7, 2025
Collaborator
michae2
left a comment
michae2
left a comment
There was a problem hiding this comment.
@michae2 reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:
Member
Author
|
TFTRs! bors r+ |
Member
Author
|
An interesting side-effect of using sql-instance-based planning is that it protects placement of TableReaders against a range split within SQL row. This is the case because we stitch together spans that look like they belong to the same SQL row cockroach/pkg/sql/distsql_physical_planner.go Line 1695 in cddd383 |
craig bot
pushed a commit
that referenced
this pull request
Nov 8, 2025
157077: sql: remove gossip-based DistSQL physical planning r=yuzefovich a=yuzefovich In 25.1 release we switched to using SQL-instance-based DistSQL physical planning but left gossip-based planning just in case (controlled via a cluster setting). We haven't seen any fallout from that, and given that many different workloads have been upgraded to 25.2, it seems safe to completely remove gossip-based planning now. Epic: None Release note: None 157079: sql: speed up recently added TestTruncateLarge r=yuzefovich a=yuzefovich We just saw a timeout in tests where 15m limit was exceeded because more than 11m were consumed by TestTruncateLarge. In order to speed up the test, this commit reduces the number of tables affected as well as runs both subtests in parallel (which - hopefully - should be ok given that we skip this test under all heavy configs). Fixes: #156998. Release note: None 157086: go.mod: bump Pebble to f11535e4f8ec r=annrpom a=annrpom Changes: * [`f11535e4`](cockroachdb/pebble@f11535e4) db: use Peek in TestVersionSetSeqNums * [`1ba71aa2`](cockroachdb/pebble@1ba71aa2) wal: consolidate LogRecycler.[Set]MinRecycleLogNum * [`82d592ec`](cockroachdb/pebble@82d592ec) db: document that multiple flushableEntries may share a logNum * [`9b012186`](cockroachdb/pebble@9b012186) db: add metric encapsulating blob file rewrite bytes read, written * [`b0c3d6c1`](cockroachdb/pebble@b0c3d6c1) db: disable writing to value blocks if `DisableSeparationBySuffix` is true * [`562c8d4d`](cockroachdb/pebble@562c8d4d) internal/manifest: document relationship between LastSeqNum and WAL seqnums * [`6d692923`](cockroachdb/pebble@6d692923) github: make sure the AI review bot picks up a PR with label added after creation Release note: none. Epic: none. Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com> Co-authored-by: Annie Pompa <annie@cockroachlabs.com>
Contributor
|
Build failed (retrying...): |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 25.1 release we switched to using SQL-instance-based DistSQL physical planning but left gossip-based planning just in case (controlled via a cluster setting). We haven't seen any fallout from that, and given that many different workloads have been upgraded to 25.2, it seems safe to completely remove gossip-based planning now.
Epic: None
Release note: None