Skip to content

Conversation

@annrpom
Copy link
Contributor

@annrpom annrpom commented Nov 7, 2025

Changes:

  • f11535e4 db: use Peek in TestVersionSetSeqNums
  • 1ba71aa2 wal: consolidate LogRecycler.[Set]MinRecycleLogNum
  • 82d592ec db: document that multiple flushableEntries may share a logNum
  • 9b012186 db: add metric encapsulating blob file rewrite bytes read, written
  • b0c3d6c1 db: disable writing to value blocks if DisableSeparationBySuffix is true
  • 562c8d4d internal/manifest: document relationship between LastSeqNum and WAL seqnums
  • 6d692923 github: make sure the AI review bot picks up a PR with label added after creation

Release note: none.
Epic: none.

Changes:

 * [`f11535e4`](cockroachdb/pebble@f11535e4) db: use Peek in TestVersionSetSeqNums
 * [`1ba71aa2`](cockroachdb/pebble@1ba71aa2) wal: consolidate LogRecycler.[Set]MinRecycleLogNum
 * [`82d592ec`](cockroachdb/pebble@82d592ec) db: document that multiple flushableEntries may share a logNum
 * [`9b012186`](cockroachdb/pebble@9b012186) db: add metric encapsulating blob file rewrite bytes read, written
 * [`b0c3d6c1`](cockroachdb/pebble@b0c3d6c1) db: disable writing to value blocks if `DisableSeparationBySuffix` is true
 * [`562c8d4d`](cockroachdb/pebble@562c8d4d) internal/manifest: document relationship between LastSeqNum and WAL seqnums
 * [`6d692923`](cockroachdb/pebble@6d692923) github: make sure the AI review bot picks up a PR with label added after creation

Release note: none.
Epic: none.
@annrpom annrpom requested review from a team and xxmplus November 7, 2025 21:20
@annrpom annrpom requested a review from a team as a code owner November 7, 2025 21:20
@annrpom annrpom requested a review from jbowens November 7, 2025 21:20
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@annrpom
Copy link
Contributor Author

annrpom commented Nov 7, 2025

TFTR! ('-')7

bors r+

craig bot pushed a commit that referenced this pull request Nov 7, 2025
157086: go.mod: bump Pebble to f11535e4f8ec r=annrpom a=annrpom

Changes:

 * [`f11535e4`](cockroachdb/pebble@f11535e4) db: use Peek in TestVersionSetSeqNums
 * [`1ba71aa2`](cockroachdb/pebble@1ba71aa2) wal: consolidate LogRecycler.[Set]MinRecycleLogNum
 * [`82d592ec`](cockroachdb/pebble@82d592ec) db: document that multiple flushableEntries may share a logNum
 * [`9b012186`](cockroachdb/pebble@9b012186) db: add metric encapsulating blob file rewrite bytes read, written
 * [`b0c3d6c1`](cockroachdb/pebble@b0c3d6c1) db: disable writing to value blocks if `DisableSeparationBySuffix` is true
 * [`562c8d4d`](cockroachdb/pebble@562c8d4d) internal/manifest: document relationship between LastSeqNum and WAL seqnums
 * [`6d692923`](cockroachdb/pebble@6d692923) github: make sure the AI review bot picks up a PR with label added after creation

Release note: none.
Epic: none.

157087: rangefeed: likely deflake TestRangefeedCatchupStarvation r=stevendanna a=pav-kv

Resolves #157065

Co-authored-by: Annie Pompa <annie@cockroachlabs.com>
Co-authored-by: Pavel Kalinnikov <pavel@cockroachlabs.com>
@craig
Copy link
Contributor

craig bot commented Nov 7, 2025

Build failed (retrying...):

craig bot pushed a commit that referenced this pull request Nov 8, 2025
157077: sql: remove gossip-based DistSQL physical planning r=yuzefovich a=yuzefovich

In 25.1 release we switched to using SQL-instance-based DistSQL physical planning but left gossip-based planning just in case (controlled via a cluster setting). We haven't seen any fallout from that, and given that many different workloads have been upgraded to 25.2, it seems safe to completely remove gossip-based planning now.

Epic: None
Release note: None

157079: sql: speed up recently added TestTruncateLarge r=yuzefovich a=yuzefovich

We just saw a timeout in tests where 15m limit was exceeded because more than 11m were consumed by TestTruncateLarge. In order to speed up the test, this commit reduces the number of tables affected as well as runs both subtests in parallel (which - hopefully - should be ok given that we skip this test under all heavy configs).

Fixes: #156998.
Release note: None

157086: go.mod: bump Pebble to f11535e4f8ec r=annrpom a=annrpom

Changes:

 * [`f11535e4`](cockroachdb/pebble@f11535e4) db: use Peek in TestVersionSetSeqNums
 * [`1ba71aa2`](cockroachdb/pebble@1ba71aa2) wal: consolidate LogRecycler.[Set]MinRecycleLogNum
 * [`82d592ec`](cockroachdb/pebble@82d592ec) db: document that multiple flushableEntries may share a logNum
 * [`9b012186`](cockroachdb/pebble@9b012186) db: add metric encapsulating blob file rewrite bytes read, written
 * [`b0c3d6c1`](cockroachdb/pebble@b0c3d6c1) db: disable writing to value blocks if `DisableSeparationBySuffix` is true
 * [`562c8d4d`](cockroachdb/pebble@562c8d4d) internal/manifest: document relationship between LastSeqNum and WAL seqnums
 * [`6d692923`](cockroachdb/pebble@6d692923) github: make sure the AI review bot picks up a PR with label added after creation

Release note: none.
Epic: none.

Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
Co-authored-by: Annie Pompa <annie@cockroachlabs.com>
@craig
Copy link
Contributor

craig bot commented Nov 8, 2025

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Nov 8, 2025

@craig craig bot merged commit f98eb99 into cockroachdb:master Nov 8, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants