Skip to content

Conversation

@pav-kv
Copy link
Collaborator

@pav-kv pav-kv commented Nov 7, 2025

Resolves #157065

@pav-kv pav-kv requested a review from stevendanna November 7, 2025 21:21
@pav-kv pav-kv requested a review from a team as a code owner November 7, 2025 21:21
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@stevendanna stevendanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pav-kv
Copy link
Collaborator Author

pav-kv commented Nov 7, 2025

bors r=stevendanna

craig bot pushed a commit that referenced this pull request Nov 7, 2025
157086: go.mod: bump Pebble to f11535e4f8ec r=annrpom a=annrpom

Changes:

 * [`f11535e4`](cockroachdb/pebble@f11535e4) db: use Peek in TestVersionSetSeqNums
 * [`1ba71aa2`](cockroachdb/pebble@1ba71aa2) wal: consolidate LogRecycler.[Set]MinRecycleLogNum
 * [`82d592ec`](cockroachdb/pebble@82d592ec) db: document that multiple flushableEntries may share a logNum
 * [`9b012186`](cockroachdb/pebble@9b012186) db: add metric encapsulating blob file rewrite bytes read, written
 * [`b0c3d6c1`](cockroachdb/pebble@b0c3d6c1) db: disable writing to value blocks if `DisableSeparationBySuffix` is true
 * [`562c8d4d`](cockroachdb/pebble@562c8d4d) internal/manifest: document relationship between LastSeqNum and WAL seqnums
 * [`6d692923`](cockroachdb/pebble@6d692923) github: make sure the AI review bot picks up a PR with label added after creation

Release note: none.
Epic: none.

157087: rangefeed: likely deflake TestRangefeedCatchupStarvation r=stevendanna a=pav-kv

Resolves #157065

Co-authored-by: Annie Pompa <annie@cockroachlabs.com>
Co-authored-by: Pavel Kalinnikov <pavel@cockroachlabs.com>
@craig
Copy link
Contributor

craig bot commented Nov 7, 2025

Build failed (retrying...):

@pav-kv
Copy link
Collaborator Author

pav-kv commented Nov 8, 2025

bors retry

@craig
Copy link
Contributor

craig bot commented Nov 8, 2025

Already running a review

@pav-kv
Copy link
Collaborator Author

pav-kv commented Nov 8, 2025

bors cancel

@craig
Copy link
Contributor

craig bot commented Nov 8, 2025

Canceled.

@pav-kv
Copy link
Collaborator Author

pav-kv commented Nov 8, 2025

bors r+

@craig
Copy link
Contributor

craig bot commented Nov 8, 2025

@craig craig bot merged commit 865c23b into cockroachdb:master Nov 8, 2025
24 checks passed
@pav-kv pav-kv deleted the bump-timeout branch November 8, 2025 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kv/kvclient/rangefeed: TestRangefeedCatchupStarvation failed

3 participants