Skip to content

[WIP, DNM] sql,sqlstats: Support fingerprint normalization#158641

Draft
kyle-a-wong wants to merge 1 commit intocockroachdb:masterfrom
kyle-a-wong:fp_normalization
Draft

[WIP, DNM] sql,sqlstats: Support fingerprint normalization#158641
kyle-a-wong wants to merge 1 commit intocockroachdb:masterfrom
kyle-a-wong:fp_normalization

Conversation

@kyle-a-wong
Copy link
Copy Markdown
Contributor

Epic: None
Release note: None

@blathers-crl
Copy link
Copy Markdown

blathers-crl Bot commented Dec 2, 2025

Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@cockroach-teamcity
Copy link
Copy Markdown
Member

🔴 Sysbench [SQL, 3node, oltp_read_write]
Metric Old Commit New Commit Delta Note
🔴 sec/op 11.00m ±1% 11.51m ±1% +4.59% p=0.000 n=15
🔴 allocs/op 8.021k ±2% 8.619k ±0% +7.46% p=0.000 n=15
Reproduce

benchdiff binaries:

mkdir -p benchdiff/09b33e6/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/09b33e69b00ac8afd545f7f0eb394694836cbd84/bin/pkg_sql_tests benchdiff/09b33e6/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/09b33e6/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/133dc2e/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/133dc2e3854b22860a60f8bdd4e19031a01bb6ce/bin/pkg_sql_tests benchdiff/133dc2e/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/133dc2e/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests

benchdiff command:

benchdiff --run=^BenchmarkSysbench/SQL/3node/oltp_read_write$ --old=133dc2e --new=09b33e6 ./pkg/sql/tests
🟢 Sysbench [KV, 3node, oltp_read_only]
Metric Old Commit New Commit Delta Note
sec/op 3.372m ±1% 3.412m ±1% ~ p=0.106 n=15
🟢 allocs/op 2.082k ±0% 2.060k ±0% -1.06% p=0.000 n=15
Reproduce

benchdiff binaries:

mkdir -p benchdiff/09b33e6/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/09b33e69b00ac8afd545f7f0eb394694836cbd84/bin/pkg_sql_tests benchdiff/09b33e6/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/09b33e6/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/133dc2e/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/133dc2e3854b22860a60f8bdd4e19031a01bb6ce/bin/pkg_sql_tests benchdiff/133dc2e/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/133dc2e/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests

benchdiff command:

benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_read_only$ --old=133dc2e --new=09b33e6 ./pkg/sql/tests
⚪ Sysbench [KV, 3node, oltp_write_only]
Metric Old Commit New Commit Delta Note
sec/op 3.814m ±1% 3.820m ±2% ~ p=0.595 n=15
allocs/op 4.162k ±0% 4.155k ±0% -0.17% p=0.003 n=15
Reproduce

benchdiff binaries:

mkdir -p benchdiff/09b33e6/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/09b33e69b00ac8afd545f7f0eb394694836cbd84/bin/pkg_sql_tests benchdiff/09b33e6/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/09b33e6/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/133dc2e/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/133dc2e3854b22860a60f8bdd4e19031a01bb6ce/bin/pkg_sql_tests benchdiff/133dc2e/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/133dc2e/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests

benchdiff command:

benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_write_only$ --old=133dc2e --new=09b33e6 ./pkg/sql/tests
Artifacts

download:

mkdir -p new
gcloud storage cp gs://cockroach-microbench-ci/artifacts/09b33e69b00ac8afd545f7f0eb394694836cbd84/19874852437-1/\* new/
mkdir -p old
gcloud storage cp gs://cockroach-microbench-ci/artifacts/133dc2e3854b22860a60f8bdd4e19031a01bb6ce/19874852437-1/\* old/

built with commit: 09b33e69b00ac8afd545f7f0eb394694836cbd84

@cockroach-teamcity cockroach-teamcity added X-perf-check Microbenchmarks CI: Added to a PR if a performance regression is detected and should be checked X-perf-gain Microbenchmarks CI: Added if a performance gain is detected labels Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

X-perf-check Microbenchmarks CI: Added to a PR if a performance regression is detected and should be checked X-perf-gain Microbenchmarks CI: Added if a performance gain is detected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants