Skip to content

Conversation

@blathers-crl
Copy link

@blathers-crl blathers-crl bot commented Dec 10, 2025

Backport 2/2 commits from #158349 on behalf of @pav-kv.


This PR passes the information about newly created replicas into the raft asserter. This helps tracking the applied state more accurately. Previously, there was a window of time (between a replica splits out and applies the first non-trivial command) during which its tracked applied state is zero while the real one is not.

Resolves #157765, #158624
Informs #158247


Release justification: test-only fix
Resolves #159206, #158624

This commit adds a testing knob that observes all RHS replica creations
during splits. This helps tracking replica lifecycle in tests more
accurately (e.g. see the next commit).

Epic: none
Release note: none
This commit passes the information about newly created replicas into the
raft asserter. This helps tracking the applied state more accurately.
Previously, there was a window of time (between a replica splits out and
applies the first non-trivial command) during which its tracked applied
state is zero while the real one is not.

Epic: none
Release note: none
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-26.1-158349 branch from a73dc68 to 9587fd6 Compare December 10, 2025 22:57
@blathers-crl blathers-crl bot requested a review from a team as a code owner December 10, 2025 22:57
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Dec 10, 2025
@blathers-crl
Copy link
Author

blathers-crl bot commented Dec 10, 2025

Thanks for opening a backport.

Before merging, please confirm that the change does not break backwards compatibility and otherwise complies with the backport policy. Include a brief release justification in the PR description explaining why the backport is appropriate. All backports must be reviewed by the TL for the owning area. While the stricter LTS policy does not yet apply, please exercise judgment and consider gating non-critical changes behind a disabled-by-default feature flag when appropriate.

@blathers-crl blathers-crl bot added backport Label PR's that are backports to older release branches T-kv KV Team labels Dec 10, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@pav-kv pav-kv merged commit e15b1ec into release-26.1 Dec 11, 2025
14 of 15 checks passed
@pav-kv pav-kv deleted the blathers/backport-release-26.1-158349 branch December 11, 2025 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. T-kv KV Team target-release-26.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants