pkg/cli: enhance tsdump functionality to work with explicit static list of metrics#159269
Draft
Abhinav1299 wants to merge 1 commit intocockroachdb:release-25.3from
Draft
pkg/cli: enhance tsdump functionality to work with explicit static list of metrics#159269Abhinav1299 wants to merge 1 commit intocockroachdb:release-25.3from
Abhinav1299 wants to merge 1 commit intocockroachdb:release-25.3from
Conversation
158626: pkg/cli: enhance tsdump functionality to work with explicit static list of metrics r=Abhinav1299 a=Abhinav1299 This commit introduces the ability to specify a list of metrics to dump via a file using the `--metrics-list-file` flag in the `debug tsdump` command. The implementation includes: - A new `metricsListFile` option in the `debugTimeSeriesDumpOpts` struct to hold the file path. - Functions to read and parse the metrics list file, supporting both literal metric names and regex patterns. - Logic to expand the specified metrics into their corresponding internal timeseries names, including handling of histogram metrics. This enhancement allows users to selectively dump metrics, improving the flexibility and usability of the tsdump command. Part of: CRDB-57350 Epic: CRDB-55082 Release note: none Co-authored-by: Abhinav1299 <abhinav.gupta@cockroachlabs.com>
|
Thanks for opening a backport. Before merging, please confirm that the change does not break backwards compatibility and otherwise complies with the backport policy. Include a brief release justification in the PR description explaining why the backport is appropriate. All backports must be reviewed by the TL for the owning area. While the stricter LTS policy does not yet apply, please exercise judgment and consider gating non-critical changes behind a disabled-by-default feature flag when appropriate. |
blathers-crl
Bot
added
the
backport
Member
|
This change is |
Abhinav1299
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces the ability to specify a list of metrics to dump via a file using the
--metrics-list-fileflag in thedebug tsdumpcommand. The implementation includes:metricsListFileoption in thedebugTimeSeriesDumpOptsstruct to hold the file path.This enhancement allows users to selectively dump metrics, improving the flexibility and usability of the tsdump command.
Part of: CRDB-57350
Epic: CRDB-55082
Release note: none
Release justification: Supportability improvement that will help to detect/debug production issue.