Skip to content

Conversation

@rickystewart
Copy link
Collaborator

@rickystewart rickystewart commented Dec 22, 2025

Backport 1/1 commits from #160014 on behalf of @rickystewart.


Release note: none
Epic: DEVINF-1582


Release justification: Non-production code changes

Release note: none
Epic: DEVINF-1582
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Dec 22, 2025
@blathers-crl blathers-crl bot requested a review from annaw2193 December 22, 2025 18:43
@blathers-crl
Copy link

blathers-crl bot commented Dec 22, 2025

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes. Includes test-only changes, build system changes, etc.
  • Fixes for serious issues. Defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to.

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl bot added backport Label PR's that are backports to older release branches T-code-systems labels Dec 22, 2025
@blathers-crl
Copy link

blathers-crl bot commented Dec 22, 2025

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@blathers-crl
Copy link

blathers-crl bot commented Dec 22, 2025

✅ PR #160019 is compliant with backport policy

Confidence: high
Backward compatible: true
Explanation: The PR addresses changes in the pkg/cmd/ci-stress/main.go, which is a development tool as listed under the pattern pkg/cmd/roachtest/. Such files are included in the exception list for non-production and test-only changes. Therefore, they do not need to meet the critical bug justification or feature flag requirements. Moreover, the PR body mentions a 'Release justification: Non-production code changes', which exempts it from regular backport policy requirements. Although the pattern mentioned in the policy is not exactly pkg/cmd/ci-stress/, it falls under the broader scope of development tools similar to pkg/cmd/roachtest/, justifying the exemption.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@rickystewart rickystewart merged commit a7392b1 into cockroachdb:release-24.3 Dec 22, 2025
17 checks passed
@rickystewart rickystewart deleted the blathers/backport-release-24.3-160014 branch December 22, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. T-code-systems target-release-24.3.25

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants