prototype: sql: reuse insertFastPathNodes#160735
Draft
mgartner wants to merge 5 commits intocockroachdb:masterfrom
Draft
prototype: sql: reuse insertFastPathNodes#160735mgartner wants to merge 5 commits intocockroachdb:masterfrom
mgartner wants to merge 5 commits intocockroachdb:masterfrom
Conversation
Release note: None
The `Reuse` and `Destroy` methods have been added to the `planNode` interface. All implementations of `Reuse` are currently no-ops that return `ok=false`. All implementations of `Destroy` are currently no-ops. In the future these methods will allow `planNode` trees to be cached and reused for multiple executions. See the inline comments for more details. Release note: None
Execbuilder now tracks the timestamps of stats collections and forecasts instead of the duration between the current time and those timestamps. This decouples execbuild-time from execution-time and will allow for accurate instrumentation of time-since-stats-collection and time-since-stats-forecast when `planNode`s are cached in the future—in which case execbuild will only happen once for the query, not for every execution. Release note: None
Metrics collected at execbuild-time are now encapsulated in `exec.Metrics` and applied to an `instrumentationHelper` with the `RecordExecMetrics` method. This is a mechanical change with no change in behavior. Unit tests have also been added for `exec.Metrics` and `exec.IndexesUsed`. Release note: None
Release note: None
Member
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sql/tests: add sysbench oltp_delete_insert_only benchmark
Release note: None
sql: add Reuse and Destroy methods to planNode interface
The
ReuseandDestroymethods have been added to theplanNodeinterface. All implementations of
Reuseare currently no-ops thatreturn
ok=false. All implementations ofDestroyare currentlyno-ops. In the future these methods will allow
planNodetrees to becached and reused for multiple executions. See the inline comments for
more details.
Release note: None
opt: track stats timestamps in execbuilder instead of durations
Execbuilder now tracks the timestamps of stats collections and forecasts
instead of the duration between the current time and those timestamps.
This decouples execbuild-time from execution-time and will allow for
accurate instrumentation of time-since-stats-collection and
time-since-stats-forecast when
planNodes are cached in the future—inwhich case execbuild will only happen once for the query, not for every
execution.
Release note: None
opt: refactor execbuilder metrics
Metrics collected at execbuild-time are now encapsulated in
exec.Metricsand applied to aninstrumentationHelperwith theRecordExecMetricsmethod. This is a mechanical change with no changein behavior. Unit tests have also been added for
exec.Metricsandexec.IndexesUsed.Release note: None
sql: reuse insertFastPathNodes
Release note: None