Skip to content

ui,sql: introduce a way to identify query plan distribution shifts#161011

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
jasonlmfong:jf/plan-shift
Jan 21, 2026
Merged

ui,sql: introduce a way to identify query plan distribution shifts#161011
craig[bot] merged 1 commit intocockroachdb:masterfrom
jasonlmfong:jf/plan-shift

Conversation

@jasonlmfong
Copy link
Member

Add a new timeseries bargraph under the statement page - explain plan tab. This graph is powered by a new protobuff that returns statement execution counts, grouped by plan gists and timestamps.

Partial: #118579
Epic: None
Release Note(ui): introduce a new way to investigate query plan distributions over time.

@jasonlmfong jasonlmfong requested review from a team as code owners January 13, 2026 20:40
@jasonlmfong jasonlmfong requested review from angles-n-daemons and removed request for a team January 13, 2026 20:40
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jasonlmfong jasonlmfong marked this pull request as draft January 13, 2026 21:12
@jasonlmfong jasonlmfong marked this pull request as ready for review January 14, 2026 15:14
@github-actions
Copy link
Contributor

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

  • If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
  • If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

@github-actions github-actions bot added the o-AI-Review-Potential-Issue-Detected AI reviewer found potential issue. Never assign manually—auto-applied by GH action only. label Jan 14, 2026
@github-actions
Copy link
Contributor

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

  • If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
  • If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

@jasonlmfong jasonlmfong force-pushed the jf/plan-shift branch 4 times, most recently from 3136b5d to d33b6df Compare January 14, 2026 17:40
Copy link
Collaborator

@alyshanjahani-crl alyshanjahani-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

B/c this part of the code and the UI aren't used much I'm fine with this, but before merging try and take a look to see if you can refactor / clean up this
getStatementDetailsPerAggregatedTs + getStatementDetailsPerPlanHash + getStatementDetailsPerAggregateadTsAndPlanHash

Also none of this statement details code has tests, even if you can add a small amount of coverage that would be great.

Add a new timeseries bargraph under the statement page - explain plan tab.
This graph is powered by a new protobuff that returns statement execution counts, grouped by
plan gists and timestamps.

Partial: cockroachdb#118579
Epic: None
Release Note(ui): introduce a new way to investigate query plan distributions over time.
@jasonlmfong
Copy link
Member Author

TFTR

bors r=alyshanjahani-crl

@craig
Copy link
Contributor

craig bot commented Jan 21, 2026

@craig craig bot merged commit 01d347b into cockroachdb:master Jan 21, 2026
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

o-AI-Review-Potential-Issue-Detected AI reviewer found potential issue. Never assign manually—auto-applied by GH action only. target-release-26.2.0 v26.2.0-prerelease

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants