ui,sql: introduce a way to identify query plan distribution shifts#161011
ui,sql: introduce a way to identify query plan distribution shifts#161011craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
ae0d232 to
7b96c41
Compare
Potential Bug(s) DetectedThe three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation. Next Steps: Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary. After you review the findings, please tag the issue as follows:
|
7b96c41 to
2be16d1
Compare
Potential Bug(s) DetectedThe three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation. Next Steps: Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary. After you review the findings, please tag the issue as follows:
|
3136b5d to
d33b6df
Compare
alyshanjahani-crl
left a comment
There was a problem hiding this comment.
B/c this part of the code and the UI aren't used much I'm fine with this, but before merging try and take a look to see if you can refactor / clean up this
getStatementDetailsPerAggregatedTs + getStatementDetailsPerPlanHash + getStatementDetailsPerAggregateadTsAndPlanHash
Also none of this statement details code has tests, even if you can add a small amount of coverage that would be great.
Add a new timeseries bargraph under the statement page - explain plan tab. This graph is powered by a new protobuff that returns statement execution counts, grouped by plan gists and timestamps. Partial: cockroachdb#118579 Epic: None Release Note(ui): introduce a new way to investigate query plan distributions over time.
d33b6df to
3aefc8b
Compare
|
TFTR bors r=alyshanjahani-crl |
Add a new timeseries bargraph under the statement page - explain plan tab. This graph is powered by a new protobuff that returns statement execution counts, grouped by plan gists and timestamps.
Partial: #118579
Epic: None
Release Note(ui): introduce a new way to investigate query plan distributions over time.