sql: report error when db provided in show regions stmts does not exist#161014
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jan 14, 2026
Merged
sql: report error when db provided in show regions stmts does not exist#161014craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Previously, the SHOW REGIONS and SHOW SUPER REGIONS statements would succeed when provided a database name that does not exist. This commit aligns the behavior of these statements with other SHOW statements and returns a database does not exist error when appropriate. Epic: none Fixes: cockroachdb#113782 Release note (bug fix): An error will now be reported when the database provided in a SHOW REGIONS or SHOW SUPER REGIONS statement does not exist. This bug was present since version 21.1.
Member
|
This change is |
rafiss
approved these changes
Jan 14, 2026
Collaborator
rafiss
left a comment
rafiss
left a comment
There was a problem hiding this comment.
lgtm! whenever you're ready, this can be merged by writing bors r+ in a github comment, on a line with no other text.
@rafiss made 2 comments.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @eric-alton).
pkg/ccl/logictestccl/testdata/logic_test/multi_region line 1736 at r1 (raw file):
statement error database "Delimited DB 113782" does not exist SHOW SUPER REGIONS FROM DATABASE "Delimited DB 113782"
thanks for adding good edge-case testing here! mixed-case and whitespace-containing names are a common source of bugs when it comes to implementing our introspection queries.
shghasemi
approved these changes
Jan 14, 2026
Contributor
shghasemi
left a comment
shghasemi
left a comment
There was a problem hiding this comment.
@shghasemi reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status:
Contributor
Author
|
bors r+ |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the SHOW REGIONS and SHOW SUPER REGIONS statements would succeed when provided a database name that does not exist.
This commit aligns the behavior of these statements with other SHOW statements and returns a database does not exist error when appropriate.
Epic: none
Fixes: #113782
Release note (bug fix): An error will now be reported when the database provided in a SHOW REGIONS or SHOW SUPER REGIONS statement does not exist. This bug was present since version 21.1.