colexec: plan InvariantsChecker in RunTests harness#161348
Draft
yuzefovich wants to merge 2 commits intocockroachdb:masterfrom
Draft
colexec: plan InvariantsChecker in RunTests harness#161348yuzefovich wants to merge 2 commits intocockroachdb:masterfrom
yuzefovich wants to merge 2 commits intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Previously, we could have ignored an error on the OCF reader since we didn't properly implement `Err` method. This meant storage backend errors (e.g., from S3) during import could be silently ignored, resulting in incomplete data imports without any error reported to the user. This is now fixed. Release note (bug fix): Fixed a bug where IMPORT with AVRO data using OCF format could silently lose data if the underlying storage (e.g., S3) returned an error during read. Such errors are now properly reported. Other formats (specified via `data_as_binary_records` and `data_as_json_records` options) are unaffected. The bug has been present since about v20.1. Co-Authored-By: Matt White <matt.white@cockroachlabs.com> Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This should improve our test coverage (in particular, of streaming metadata propagation). Release note: None
yuzefovich
force-pushed
the
invariants-checker
branch
from
7216b79 to
2e93f4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should improve our test coverage (in particular, of streaming metadata propagation).
Epic: None
Release note: None