sql,kv: experiment with non-locking RC checks and cascades#162157
Draft
DrewKimball wants to merge 5 commits intocockroachdb:masterfrom
Draft
sql,kv: experiment with non-locking RC checks and cascades#162157DrewKimball wants to merge 5 commits intocockroachdb:masterfrom
DrewKimball wants to merge 5 commits intocockroachdb:masterfrom
Conversation
This commit adds a cluster setting - session setting pair to control experimental non-locking RC check and cascade behavior.
This commit adds a flag DisallowIntentTimestampChange to write batches which causes write intents to have lock-like behavior. In particular, intents for pending txns are not rewritten if this flag is set, so the read/write blocking behavior extends from the txn's write timestamp when the intent was written, not just the final commit timestamp. Likewise, an intent that is resolved after its txn has committed bumps the tscache to block writes from the intent's timestamp up to the final commit timestamp, similar to replicated locks. This flag is set for RC write intents when the new setting is on.
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
This commit adds a read refresh to the end of read-committed statements that have mutations. This will be used in combination with prior commits to enable non-locking RC checks and cascades.
7d9aba1 to
dd24138
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sql: add settings for non-locking RC checks+cascades
This commit adds a cluster setting - session setting pair to control
experimental non-locking RC check and cascade behavior.
sql,kv: add DisallowIntentTimestampChange flag for writes
This commit adds a flag DisallowIntentTimestampChange to write batches
which causes write intents to have lock-like behavior. In particular,
intents for pending txns are not rewritten if this flag is set, so the
read/write blocking behavior extends from the txn's write timestamp
when the intent was written, not just the final commit timestamp.
Likewise, an intent that is resolved after its txn has committed
bumps the tscache to block writes from the intent's timestamp up
to the final commit timestamp, similar to replicated locks.
This flag is set for RC write intents when the new setting is on.
sql: refresh reads after RC mutation statements
This commit adds a read refresh to the end of read-committed statements
that have mutations. This will be used in combination with prior commits
to enable non-locking RC checks and cascades.
opt: skip RC check+cascade locking when setting is on
sql: add logic tests for non-locking RC checks and cascades