oidcccl: populate estimated_last_login_time for OIDC DB Console login#164129
Merged
trunk-io[bot] merged 1 commit intocockroachdb:masterfrom Mar 11, 2026
Merged
Conversation
Contributor
|
😎 Merged successfully - details. |
Member
|
This change is |
souravcrl
force-pushed
the
oidc-dbconsole-estimatedLastLoginTime
branch
2 times, most recently
from
6e20743 to
49794f3
Compare
Contributor
Author
|
/investigate |
sanchit-CRL
reviewed
Mar 10, 2026
sanchit-CRL
approved these changes
Mar 10, 2026
Collaborator
sanchit-CRL
left a comment
sanchit-CRL
left a comment
There was a problem hiding this comment.
The last commit LGTM
souravcrl
force-pushed
the
oidc-dbconsole-estimatedLastLoginTime
branch
from
49794f3 to
669b1c5
Compare
Contributor
Author
|
tftr! /trunk merge |
Contributor
Author
|
/trunk merge stop |
Contributor
An error occurred while handling your Trunk command: |
Contributor
Author
|
/trunk cancel |
souravcrl
force-pushed
the
oidc-dbconsole-estimatedLastLoginTime
branch
from
669b1c5 to
2905998
Compare
Contributor
Author
|
/trunk merge |
Previously, when a user authenticated against the DB Console via OIDC, their `estimated_last_login_time` in the `system.users` table was not updated. This meant that administrators could not track when OIDC-authenticated users last logged in through the DB Console, creating an observability gap compared to the SQL shell path and LDAP DB Console logins where this column is already populated. This commit adds `estimated_last_login_time` population for OIDC-authenticated DB Console logins, gated behind the `security.provisioning.oidc.enabled` cluster setting. Epic: CRDB-52460 Informs: cockroachdb#147602 Release note (security update): When the `security.provisioning.oidc.enabled` cluster setting is enabled, OIDC-authenticated DB Console logins now populate the `estimated_last_login_time` column in `system.users`, allowing administrators to track when OIDC users last accessed the DB Console.
souravcrl
force-pushed
the
oidc-dbconsole-estimatedLastLoginTime
branch
from
2905998 to
88f1cb2
Compare
Contributor
Author
|
/trunk merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when a user authenticated against the DB Console via OIDC,
their
estimated_last_login_timein thesystem.userstable was notupdated. This meant that administrators could not track when
OIDC-authenticated users last logged in through the DB Console, creating
an observability gap compared to the SQL shell path and LDAP DB Console
logins where this column is already populated.
This commit adds
estimated_last_login_timepopulation forOIDC-authenticated DB Console logins, gated behind the
security.provisioning.oidc.enabledcluster setting.Epic: CRDB-48764
Release note (security update): When the
security.provisioning.oidc.enabledcluster setting is enabled,OIDC-authenticated DB Console logins now populate the
estimated_last_login_timecolumn insystem.users, allowingadministrators to track when OIDC users last accessed the DB Console.