release-26.1: changefeedccl: fix min_checkpoint_frequency=0 regression#164892
Merged
andyyang890 merged 1 commit intocockroachdb:release-26.1from Mar 5, 2026
Merged
Conversation
In adfa889, we advertently made it so that setting `min_checkpoint_frequency` to 0 would cause the changefeed's highwater to not advance/not send resolved timestamps. This patch fixes that. Release note (bug fix): In a recent change that was included in 25.4+, we inadvertently made it so that setting `min_checkpoint_frequency` to 0 would cause the changefeed's highwater to not advance/not send resolved timestamps. This bug has been fixed. Note however that setting `min_checkpoint_frequency` to lower than `500ms` is not recommended as it may cause degraded changefeed performance.
|
Thanks for opening a backport. Before merging, please confirm that the change does not break backwards compatibility and otherwise complies with the backport policy. Include a brief release justification in the PR description explaining why the backport is appropriate. All backports must be reviewed by the TL for the owning area. While the stricter LTS policy does not yet apply, please exercise judgment and consider gating non-critical changes behind a disabled-by-default feature flag when appropriate. |
blathers-crl
bot
added
backport
Member
|
This change is |
andyyang890
commented
Mar 5, 2026
| } | ||
|
|
||
| cdcTest(t, testFn) | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
Merge conflict is from this branch not having TestCoreChangefeedProgress after this test in this file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #164765.
/cc @cockroachdb/release
In adfa889, we advertently made it
so that setting
min_checkpoint_frequencyto 0 would cause the changefeed'shighwater to not advance/not send resolved timestamps. This patch fixes that.
Fixes #164866
Release note (bug fix): In a recent change that was included in 25.4+,
we inadvertently made it so that setting
min_checkpoint_frequencyto0 would cause the changefeed's highwater to not advance/not send
resolved timestamps. This bug has been fixed. Note however that setting
min_checkpoint_frequencyto lower than500msis not recommended asit may cause degraded changefeed performance.
Release justification: fixes regression of existing functionality