Skip to content

autosolve: grant access to EngFlow and run in self-hosted runners#164972

Merged
trunk-io[bot] merged 1 commit intocockroachdb:masterfrom
rickystewart:ricky/kkqmqoswnysv
Mar 6, 2026
Merged

autosolve: grant access to EngFlow and run in self-hosted runners#164972
trunk-io[bot] merged 1 commit intocockroachdb:masterfrom
rickystewart:ricky/kkqmqoswnysv

Conversation

@rickystewart
Copy link
Copy Markdown
Collaborator

The self-hosted runners have the necessary dependencies installed to run builds and tests. Meanwhile, EngFlow access will allow the agent to run these builds and tests more quickly and gain the benefit of the remote cache.

We need to add some stuff to .bazelrc.user so that claude does not have to add the EngFlow arguments to every single dev invocation.

Also set the AUTOMATION=1 env var in any invocations of claude that could possibly use the ./dev executable.

Release note: none
Epic: none

The self-hosted runners have the necessary dependencies installed to run
builds and tests. Meanwhile, EngFlow access will allow the agent to
run these builds and tests more quickly and gain the benefit of the
remote cache.

We need to add some stuff to `.bazelrc.user` so that `claude` does not
have to add the EngFlow arguments to every single `dev` invocation.

Also set the `AUTOMATION=1` env var in any invocations of `claude` that
could possibly use the `./dev` executable.

Release note: none
Epic: none
@rickystewart rickystewart requested a review from a team as a code owner March 5, 2026 23:03
@trunk-io
Copy link
Copy Markdown
Contributor

trunk-io Bot commented Mar 5, 2026

😎 Merged successfully - details.

@rickystewart rickystewart requested a review from ajstorm March 5, 2026 23:03
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Collaborator

@ajstorm ajstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change LGTM, modulo my one comment.


- name: Set up EngFlow
run: |
./build/github/get-engflow-keys.sh
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do these keys get stored? Do we have to worry about Claude accidentally trying to push them to the repo as part of the change?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They live in the /home/agent directory which Claude should not be aware of and shouldn't pollute the git workspace as far as I know.

@rickystewart
Copy link
Copy Markdown
Collaborator Author

/trunk merge

@trunk-io trunk-io Bot merged commit f0b1fc5 into cockroachdb:master Mar 6, 2026
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants