Skip to content

sql: remove experimental gate from super regions#165227

Merged
trunk-io[bot] merged 1 commit intocockroachdb:masterfrom
spilchen:gh-162481/260309/1058/supreg/remove-feature-gate
Mar 11, 2026
Merged

sql: remove experimental gate from super regions#165227
trunk-io[bot] merged 1 commit intocockroachdb:masterfrom
spilchen:gh-162481/260309/1058/supreg/remove-feature-gate

Conversation

@spilchen
Copy link
Contributor

@spilchen spilchen commented Mar 9, 2026

Super regions have been gated behind an experimental feature flag since their introduction in 22.1. Remove the gate so super regions work without requiring SET enable_super_regions = 'on'.

  • Remove isSuperRegionEnabled() and all call sites in ALTER DATABASE and CREATE DATABASE paths.
  • Retire the sql.defaults.super_regions.enabled cluster setting.
  • Deprecate the enable_super_regions session variable using makeBackwardsCompatBoolVar (hidden, always returns "on").
  • Remove the unused SetEnableSuperRegions session mutator.
  • Clean up test files and workload code that set the gate.
  • Regenerate settings docs.

Epic: CRDB-58694
Closes: #162481

Release note (sql change): The enable_super_regions session variable and sql.defaults.super_regions.enabled cluster setting are no longer required to use super regions. Super region DDL operations (ADD, DROP, ALTER SUPER REGION) now work without enabling any experimental flag. The session variable and cluster setting are deprecated; existing scripts that set them will continue to work without error.

Super regions have been gated behind an experimental feature flag since
their introduction in 22.1. Remove the gate so super regions work
without requiring `SET enable_super_regions = 'on'`.

- Remove `isSuperRegionEnabled()` and all call sites in ALTER DATABASE
  and CREATE DATABASE paths.
- Retire the `sql.defaults.super_regions.enabled` cluster setting.
- Deprecate the `enable_super_regions` session variable using
  `makeBackwardsCompatBoolVar` (hidden, always returns "on").
- Remove the unused `SetEnableSuperRegions` session mutator.
- Clean up test files and workload code that set the gate.
- Regenerate settings docs.

Epic: CRDB-58694
Closes: cockroachdb#162481

Release note (sql change): The `enable_super_regions` session variable
and `sql.defaults.super_regions.enabled` cluster setting are no longer
required to use super regions. Super region DDL operations (ADD, DROP,
ALTER SUPER REGION) now work without enabling any experimental flag.
The session variable and cluster setting are deprecated; existing
scripts that set them will continue to work without error.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@spilchen spilchen self-assigned this Mar 9, 2026
@trunk-io
Copy link
Contributor

trunk-io bot commented Mar 9, 2026

😎 Merged successfully - details.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@spilchen spilchen marked this pull request as ready for review March 10, 2026 12:51
@spilchen spilchen requested review from a team as code owners March 10, 2026 12:51
@spilchen spilchen requested review from a team, DarrylWong, ZhouXing19, mw5h, rafiss and shailendra-patel and removed request for a team and mw5h March 10, 2026 12:51
Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@spilchen
Copy link
Contributor Author

TFTR!

/trunk merge

@trunk-io trunk-io bot merged commit 7d55d58 into cockroachdb:master Mar 11, 2026
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sql: remove experimental gate from super regions for GA

3 participants