sql: add description column to SHOW ALL output #165397
Merged
trunk-io[bot] merged 1 commit intocockroachdb:masterfrom Mar 16, 2026
Merged
sql: add description column to SHOW ALL output #165397trunk-io[bot] merged 1 commit intocockroachdb:masterfrom
trunk-io[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Contributor
|
😎 Merged successfully - details. |
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
rafiss
force-pushed
the
show-all-3cols
branch
4 times, most recently
from
d8766e9 to
23675a9
Compare
PostgreSQL's SHOW ALL returns three columns: name, setting, description. CockroachDB's SHOW ALL previously only returned two: variable, value. Now that all session variables have descriptions, expose them as a third column to match PostgreSQL's behavior. This adds a `description` column to the `crdb_internal.session_variables` virtual table and includes it in the `SHOW ALL` delegate query. Resolves: cockroachdb#101715 Release note (sql change): `SHOW ALL` now returns a third column, `description`, containing a human-readable description of each session variable. This matches the PostgreSQL behavior of `SHOW ALL`. Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
fqazi
approved these changes
Mar 16, 2026
Collaborator
fqazi
left a comment
fqazi
left a comment
There was a problem hiding this comment.
@fqazi reviewed 6 files and all commit messages, and made 1 comment.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on rafiss).
Collaborator
Author
|
/trunk merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL's SHOW ALL returns three columns: name, setting, description.
CockroachDB's SHOW ALL previously only returned two: variable, value.
Now that all session variables have descriptions, expose them as a third
column to match PostgreSQL's behavior.
This adds a
descriptioncolumn to thecrdb_internal.session_variablesvirtual table and includes it in the
SHOW ALLdelegate query.Resolves: #101715
Release note (sql change):
SHOW ALLnow returns a third column,description, containing a human-readable description of each sessionvariable. This matches the PostgreSQL behavior of
SHOW ALL.