Skip to content

docs: add more release note guidance to commit msg docs#165432

Merged
trunk-io[bot] merged 1 commit intocockroachdb:masterfrom
dt:rel-note-doc
Mar 23, 2026
Merged

docs: add more release note guidance to commit msg docs#165432
trunk-io[bot] merged 1 commit intocockroachdb:masterfrom
dt:rel-note-doc

Conversation

@dt
Copy link
Contributor

@dt dt commented Mar 11, 2026

Release note: none.
Epic: none.

@dt dt requested review from rafiss and taroface March 11, 2026 15:33
@trunk-io
Copy link
Contributor

trunk-io bot commented Mar 11, 2026

😎 Merged successfully - details.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@jhlodin jhlodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposing edits based on feedback we've gotten about the usefulness of our release notes to customers trying to perform upgrades.

@rafiss rafiss changed the title docs: add more release note guidane to commit msg docs docs: add more release note guidance to commit msg docs Mar 13, 2026
Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for re-adding this!

Use one category per release note. When a change could fit multiple
categories, choose the one that makes the most sense from a user perspective.
Use the category names below verbatim -- the extraction script catches common
misspellings, but unrecognized categories end up in "Miscellaneous" for the
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Confluence page lists accepted alternate spellings for each category (e.g., backwards-incompatible change, bugfix, operational change, performance, multi-tenancy, etc.). This PR doesn't list the accepted alternates, which could be useful for authors.

Copy link
Contributor Author

@dt dt Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine we'd prefer, all else being equal, tp have the canonical form be what we actively promote via our guidance for authors, as consistency makes it easier to read/scan these. Even if the script technically accepts some alternative spellings and remaps them as needed, do we benefit from promoting the usage of those in the guide?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go ahead and land the canonical spellings for now and we can decide if we want to encourage use of alternatives in a follow-up as needed.

@jhlodin jhlodin self-requested a review March 18, 2026 19:06
Copy link
Contributor

@jhlodin jhlodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unblocking from previous comments, thanks for the discussion. More to be figured out in another forum

@jhlodin jhlodin self-requested a review March 18, 2026 19:06
Copy link
Contributor

@jhlodin jhlodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unblocking from previous comments, thanks for the discussion. More to be figured out in another forum

Copy link
Collaborator

@taroface taroface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@dt
Copy link
Contributor Author

dt commented Mar 23, 2026

TFTRs!

/trunk merge

@trunk-io trunk-io bot merged commit 4ab61ba into cockroachdb:master Mar 23, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants