sql: add pg_get_triggerdef builtin#165849
Merged
trunk-io[bot] merged 1 commit intocockroachdb:masterfrom Mar 16, 2026
Merged
Conversation
Member
|
This change is |
Contributor
|
😎 Merged directly without going through the merge queue, as the queue was empty and the PR was up to date with the target branch - details. |
bghal
approved these changes
Mar 16, 2026
Contributor
bghal
left a comment
bghal
left a comment
There was a problem hiding this comment.
Worth a comment or mention that the pretty_bool parameter isn't used?
rafiss
commented
Mar 16, 2026
Collaborator
Author
rafiss
left a comment
rafiss
left a comment
There was a problem hiding this comment.
TFTR
/trunk merge
pg_dump calls pg_catalog.pg_get_triggerdef(oid, bool) when reading triggers, which previously failed with "unknown function". Add the builtin with both the 1-arg and 2-arg overloads, joining pg_trigger against crdb_internal.create_trigger_statements to produce the CREATE TRIGGER SQL. The pretty_bool parameter is accepted but not differentiated, matching our approach for pg_get_constraintdef. Also update pg_get_constraintdef's info string from the generic notUsableInfo placeholder to a real description. Informs: cockroachdb#20296 Epic: CRDB-42942 Release note (sql change): Added the pg_get_triggerdef builtin function, which returns the CREATE TRIGGER statement for a given trigger OID. This improves PostgreSQL compatibility for databases that contain triggers. Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
rafiss
force-pushed
the
pg-gettriggerdef
branch
from
730f553 to
8ac2f3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pg_dump calls pg_catalog.pg_get_triggerdef(oid, bool) when reading triggers, which previously failed with "unknown function". Add the builtin with both the 1-arg and 2-arg overloads, joining pg_trigger against crdb_internal.create_trigger_statements to produce the CREATE TRIGGER SQL. The pretty_bool parameter is accepted but not differentiated, matching our approach for pg_get_constraintdef.
Also update pg_get_constraintdef's info string from the generic notUsableInfo placeholder to a real description.
Informs: #20296
Epic: CRDB-42942
Release note (sql change): Added the pg_get_triggerdef builtin function, which returns the CREATE TRIGGER statement for a given trigger OID. This improves PostgreSQL compatibility for databases that contain triggers.