Skip to content

release-25.4: roachtest: reduce the number of concurrent works in tpcc/create#166165

Merged
jeffswenson merged 1 commit intocockroachdb:release-25.4from
jeffswenson:backport25.4-159175
Mar 19, 2026
Merged

release-25.4: roachtest: reduce the number of concurrent works in tpcc/create#166165
jeffswenson merged 1 commit intocockroachdb:release-25.4from
jeffswenson:backport25.4-159175

Conversation

@jeffswenson
Copy link
Collaborator

Backport 1/1 commits from #159175.

/cc @cockroachdb/release

Fixes: #166164
Informs: #162008


The tpcc/create tests is a bit of a stress test for the kv writer and it's an even bigger challenge for the crud writer. In steady state, the kv writer uses ~40% cpu to replicate the workload and the crud writer uses ~60% cpu. But this test isn't checking the steady state, its building up a backlog while the initial scan runs. So the workload needs to catch up using the remaining CPU headroom, which is what causes this test to fail due to high replication latency.

Now, the test uses 1/2 the warehouse count when running the workload. This lets us use a large data load when testing the create replicated table statement and produces a manageable backlog for the crud writer to catch up on.

Release note: none
Fixes: #156185
Part of: #158439

Release justification: test only change.

The tpcc/create tests is a bit of a stress test for the kv writer and
it's an even bigger challenge for the crud writer. In steady state, the
kv writer uses ~40% cpu to replicate the workload and the crud writer
uses ~60% cpu. But this test isn't checking the steady state, its
building up a backlog while the initial scan runs. So the workload needs
to catch up using the remaining CPU headroom, which is what causes this
test to fail due to high replication latency.

Now, the test uses 1/2 the warehouse count when running the workload.
This lets us use a large data load when testing the create replicated
table statement and produces a manageable backlog for the crud writer to
catch up on.

Release note: none
Fixes: cockroachdb#156185
Part of: #1584390
@jeffswenson jeffswenson requested review from a team and rharding6373 and removed request for a team March 19, 2026 13:51
@blathers-crl
Copy link

blathers-crl bot commented Mar 19, 2026

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes OR fixes for serious issues. Non-production includes test-only changes, build system changes, etc. Serious issues are defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to. Reference the approved ENGREQ ticket in the PR body (e.g., "Fixes ENGREQ-123").

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl bot added backport Label PR's that are backports to older release branches T-cdc labels Mar 19, 2026
@blathers-crl
Copy link

blathers-crl bot commented Mar 19, 2026

✅ PR #166165 is compliant with backport policy

Confidence: high
Backward compatible: true
Explanation: The PR changes are limited to files under pkg/cmd/roachtest/, which is designated as a non-production file path in the CockroachDB Backport Policy. The changes are only applied to the test-related code, specifically the roachtest files that handle testing configurations and parameters for load and replication tests. This type of change falls under the exception for non-production and test-only changes. Additionally, the PR body includes 'Release justification: test only change,' which aligns with the policy exception for release justification. Considering these points, the PR meets the requirements and is exempt from the standard backport policy criteria.

ENGREQ Check Passed: No ENGREQ required (non-production code or serious issues).

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@blathers-crl blathers-crl bot added the backport-test-only Used to denote the backport has only non-production changes label Mar 19, 2026
@jeffswenson
Copy link
Collaborator Author

Thanks for the review!

@jeffswenson jeffswenson merged commit 142cf40 into cockroachdb:release-25.4 Mar 19, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches backport-test-only Used to denote the backport has only non-production changes T-cdc target-release-25.4.8

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants