claude: document hash-based redaction in redactability guide#166243
Open
visheshbardia wants to merge 1 commit intocockroachdb:masterfrom
Open
claude: document hash-based redaction in redactability guide#166243visheshbardia wants to merge 1 commit intocockroachdb:masterfrom
visheshbardia wants to merge 1 commit intocockroachdb:masterfrom
Conversation
visheshbardia
requested review from
a team and
arjunmahishi
and removed request for
a team
Contributor
|
Merging to
|
Member
|
This change is |
Abhinav1299
reviewed
Mar 20, 2026
.claude/rules/redactability.md
Outdated
| } | ||
|
|
||
| t.Run("hashing enabled", func(t *testing.T) { | ||
| redact.EnableHashing(nil) |
Contributor
There was a problem hiding this comment.
NIT: In the documentation above on line 67, we mentioned to always provide a salt but here we enabled hashing with nil. Can we update this?
.claude/rules/redactability.md
Outdated
Comment on lines
+50
to
+51
| | `int` | `redact.HashInt` | | ||
| | `uint` | `redact.HashUint` | |
Contributor
There was a problem hiding this comment.
In the redact PR: https://github.com/cockroachdb/redact/pull/33/files
HashInt is mapped as int64 and HashUint is mapped as uint64. Can we update here the same
Contributor
Author
There was a problem hiding this comment.
good catch, updated.
Thanks!
visheshbardia
force-pushed
the
update-claude-rule-redaction
branch
from
075721e to
b6ba26a
Compare
Update the redactability Claude rule to cover the recently enabled hash-based redaction support from cockroachdb/redact. Documents all Hash* wrapper types (HashString, HashInt, HashUint, etc.), the HashValue marker interface for custom types, configuration via the log config, and testing guidance. Release note: None
cockroach-teamcity
added
the
X-perf-gain
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the redactability Claude rule to cover the recently enabled hash-based redaction support from cockroachdb/redact. Documents all Hash* wrapper types (HashString, HashInt, HashUint, etc.), the HashValue marker interface for custom types, configuration via the log config, and testing guidance.
Epic: CC-35037
Release note: None