cli: support lock table keys in debug decode-key#166366
Open
ameyapatil1986 wants to merge 1 commit intocockroachdb:masterfrom
Open
cli: support lock table keys in debug decode-key#166366ameyapatil1986 wants to merge 1 commit intocockroachdb:masterfrom
ameyapatil1986 wants to merge 1 commit intocockroachdb:masterfrom
Conversation
decode-key previously only accepted MVCC keys or raw user keys. Lock table keys are stored as engine keys with a lock version suffix; try DecodeEngineKey after DecodeMVCCKey and print lock table keys consistently with other debug tooling. Fixes cockroachdb#114425 Release note (cli change): The debug decode-key command can now decode lock table engine keys, not only MVCC keys and unversioned user keys. Made-with: Cursor
Contributor
|
Merging to
|
|
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
decode-key previously only accepted MVCC keys or raw user keys. Lock table keys are stored as engine keys with a lock version suffix; try DecodeEngineKey after DecodeMVCCKey and print lock table keys consistently with other debug tooling.
Fixes #114425
Release note (cli change): The debug decode-key command can now decode lock table engine keys, not only MVCC keys and unversioned user keys.
Testing:
./dev test pkg/cli -f=TestDebugDecodeKeys -v