kvserver: deflake TestRebalancingAndCrossRegionZoneSnapshotMetrics#167558
Merged
trunk-io[bot] merged 1 commit intocockroachdb:masterfrom Apr 7, 2026
Merged
kvserver: deflake TestRebalancingAndCrossRegionZoneSnapshotMetrics#167558trunk-io[bot] merged 1 commit intocockroachdb:masterfrom
trunk-io[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Snapshot delegation is enabled by default, and `getSenderReplicas` can pick server[1] as a delegate for the second snapshot if server[0] is momentarily considered unhealthy by the store pool. When that happens, the sent-bytes metrics land on the wrong server, failing the test's assertions. The math checks out too -- `599 + 822 = 1421 = totalSnapshotLength`, exactly what you'd expect from a delegated snapshot. Fixes cockroachdb#167004 H/t to the investigator agent for the analysis on this one. Release note: None Epic: none Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
Contributor
|
😎 Merged successfully - details. |
Member
|
This change is |
arulajmani
added
the
backport-all
tbg
approved these changes
Apr 7, 2026
This was referenced Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snapshot delegation is enabled by default, and
getSenderReplicascanpick server[1] as a delegate for the second snapshot if server[0] is
momentarily considered unhealthy by the store pool. When that happens,
the sent-bytes metrics land on the wrong server, failing the test's
assertions.
Disable delegation in this test, same as we already do in
TestSnapshotsToDrainingOrDecommissioningNodes.Fixes-26.1 #167004
Epic: none
Release note: None