security/oidcauth: fix TestOIDCAuthorization_RoleGrantAndRevoke timeout flake

[cockroach-teamcity]

The test was failing with context deadline exceeded (Client.Timeout exceeded while awaiting headers) because the HTTP client used the
default 10-second timeout from GetHTTPClient(). Under the race
detector, the OIDC callback handler (which acquires a mutex, performs
token exchange, and executes SQL role grant/revoke operations) can
exceed this timeout.

Other OIDC tests in the same package already set `client.Timeout = 30

• time.Second with the comment "Set a reasonable timeout for the client to prevent flakiness under stress." This change applies the same 30-second timeout to the three authorization test functions (TestOIDCAuthorization_TokenPaths, TestOIDCAuthorization_UserinfoPaths, and TestOIDCAuthorization_RoleGrantAndRevoke`) that were missing it.

Additionally, the retry loop in performOIDCLogin is removed because
it masked the root cause (insufficient timeout) and had correctness
issues with reusing http.Request objects after failed Do calls.
With the proper timeout, retries are unnecessary.

Resolves: #167912
Epic: none

Release note: None

Generated by Claude Code Auto-Solver
Co-Authored-By: Claude noreply@anthropic.com

---

 pkg/security/oidcauth/authorization_oidc_test.go | 47 +++---------------------
 1 file changed, 5 insertions(+), 42 deletions(-)

This PR was auto-generated by issue-autosolve using Claude Code.
Please review carefully before approving.

[trunk-io]

😎 Merged successfully - details.

[cockroach-teamcity]

This change is 

[souravcrl]

Same retry logic worked here, so approving this https://github.com/cockroachdb/cockroach/pull/161381/changes

[souravcrl]

/trunk merge

[github-actions]

[autosolve-response]

I reviewed the comments but no code changes were necessary.

Analysis:

The comment is `/trunk merge` from `souravcrl`, which is a merge command — not code review feedback requiring changes. This is simply a command to merge the PR, not a request for code modifications.

No code changes are needed to address this comment.

CHANGES_RESULT - SUCCESS

Workflow run

[blathers-crl]

Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches.

---

Issue #167912: branch-release-26.1, branch-release-26.2.

---

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}

[blathers-crl]

Encountered an error creating backports. Some common things that can go wrong:

1. The backport branch might have already existed.
2. There was a merge conflict.
3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

---

💡 Consider backporting to the fork repo instead of the main repo. See instructions for more details.

merge conflict cherry-picking 3691c2d to blathers/backport-release-25.4-167913

Backport to branch 25.4.x failed. See errors above.

---

💡 Consider backporting to the fork repo instead of the main repo. See instructions for more details.

merge conflict cherry-picking 3691c2d to blathers/backport-release-26.1-167913

Backport to branch 26.1.x failed. See errors above.

---

💡 Consider backporting to the fork repo instead of the main repo. See instructions for more details.

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}