allocator: disable follow-the-workload when MMA is enabled#167939
Merged
Conversation
Contributor
|
😎 Merged successfully - details. |
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
tbg
approved these changes
Apr 9, 2026
Previously, follow-the-workload lease transfers via the lease queue were still active when the MMA was enabled, potentially conflicting with its rebalancing decisions. Now, shouldTransferLeaseForAccessLocality returns early when the rebalancing mode is MMA, disabling follow-the-workload while preserving lease preference enforcement, IO overload shedding, and lease count convergence. Fixes: cockroachdb#153866 Epic: CRDB-54644 Release note: None
Contributor
Author
|
/trunk merge |
angeladietz
force-pushed
the
mma-ftw
branch
2 times, most recently
from
9154765 to
eae76e7
Compare
|
Detected infrastructure failure (matched: self-hosted runner lost communication with the server). Automatically rerunning failed jobs. (run link) |
Contributor
Author
|
blathers backport 26.2 |
|
Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches. Issue #153866: branch-release-26.2. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
tbg
added a commit
to 5hubh4m/cockroach
that referenced
this pull request
Apr 29, 2026
Triages 28 new author-based candidates as ignored: admission/AC SQL CPU token workstream, SQL/UI/docs/CI changes, roachtest infra, and unrelated kvserver/storage work. Also ignores cockroachdb#167861 (touches non-mma kvserver load/allocator code), cockroachdb#167655 (test deflake), and cockroachdb#167696 (roachtest-only scoring). Leaves 4 PRs to backport: cockroachdb#167051, cockroachdb#167110 (asim configs/docs), cockroachdb#167897 (COCKROACH_DISABLE_MMA killswitch), cockroachdb#167939 (disable follow-the-workload when MMA enabled). Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
tbg
added a commit
to 5hubh4m/cockroach
that referenced
this pull request
Apr 29, 2026
…orted, invisible to script) cockroachdb#167897 was cherry-picked manually (b5f0518, d3ea308, 5bae83c) without backport-tool's PR-ref convention. cockroachdb#167939 was bundled into the backport PR cockroachdb#168475 whose subject doesn't list the original PR number. Both surfaced as conflicts during a backport run; verified the changes are already on release-26.2. Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, follow-the-workload lease transfers via the lease queue were
still active when the MMA was enabled, potentially conflicting with its
rebalancing decisions. Now, shouldTransferLeaseForAccessLocality returns
early when the rebalancing mode is MMA, disabling follow-the-workload
while preserving lease preference enforcement, IO overload shedding, and
lease count convergence.
Fixes: #153866
Epic: CRDB-54644
Release note: None