release-26.2: kvserver: stop wrapping AbortSpan errors as ReplicaCorruptionError#168014
Merged
Merged
Conversation
This is the last remaining production call site that wraps errors as `ReplicaCorruptionError`. A failure to read from the AbortSpan is not indicative of replica corruption and should not crash the node. This is a minimal fix suitable for backporting. A follow-up commit removes the now-dead `ReplicaCorruptionError` infrastructure entirely. Informs: cockroachdb#165558 Release note (bug fix): Fixed a bug where transient I/O errors reading from the AbortSpan were misidentified as replica corruption, causing the node to crash. These errors are now returned to the caller as regular errors. Epic: none Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
😎 Merged successfully - details. |
|
Thanks for opening a backport. Before merging, please confirm that the change does not break backwards compatibility and otherwise complies with the backport policy. Include a brief release justification in the PR description explaining why the backport is appropriate. All backports must be reviewed by the TL for the owning area. While the stricter LTS policy does not yet apply, please exercise judgment and consider gating non-critical changes behind a disabled-by-default feature flag when appropriate. |
blathers-crl
Bot
added
backport
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
tbg
changed the title
…rapping The backport of the AbortSpan error change from cockroachdb#167295 carried the production code fix but missed the corresponding test update. The test still asserted that the error contained "replica corruption" and that the node fataled, but these behaviors were removed by the backported change. Update the test to match: expect "could not read from AbortSpan" instead of "replica corruption", and remove the fatal exit assertion. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
arulajmani
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 1/2 commits from #167295.
/cc @cockroachdb/release
AbortSpan read errors were wrapped as
ReplicaCorruptionError, causing thenode to fatal via
setCorruptRaftMuLocked. This was overly aggressive: afailure to read from the AbortSpan is not indicative of replica corruption.
Transient I/O errors would crash the node instead of being returned to the
caller.
This is the last remaining production call site that produces
ReplicaCorruptionError(the split/merge trigger wrapping was removed in#167289).
Informs: #165558
Epic: none
Release justification: Low-risk bug fix. One-line change that stops wrapping
a non-corruption error as
ReplicaCorruptionError, preventing unnecessarynode crashes on transient I/O errors during AbortSpan reads.