kvstorage: stage a WAG event for replica subsumption#168333
Merged
trunk-io[bot] merged 3 commits intocockroachdb:masterfrom Apr 15, 2026
Merged
kvstorage: stage a WAG event for replica subsumption#168333trunk-io[bot] merged 3 commits intocockroachdb:masterfrom
trunk-io[bot] merged 3 commits intocockroachdb:masterfrom
Conversation
Contributor
|
😎 Merged successfully - details. |
Member
|
This change is |
|
Detected infrastructure failure (matched: ). Automatically rerunning failed jobs. (run link) |
1 similar comment
|
Detected infrastructure failure (matched: ). Automatically rerunning failed jobs. (run link) |
arulajmani
force-pushed
the
rse-subsume-wag-event
branch
from
423aa0e to
a18afa3
Compare
|
Detected infrastructure failure (matched: self-hosted runner lost communication with the server). Automatically rerunning failed jobs. (run link) |
pav-kv
approved these changes
Apr 15, 2026
Collaborator
pav-kv
left a comment
pav-kv
left a comment
There was a problem hiding this comment.
LGTM % rebase. I think one of the intermediate commits will be temporarily broken after the fixup in the parent PR (a stricter assertion).
Release note: None Epic: None
Extract printBatch, mutate, mutateSep, and the engine subtest boilerplate into reusable test helpers. Burns down a TODO on replicaInfo. The next commit introduces a TestSubsumeReplica that'll lean on these. Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
SubsumeReplica now writes an EventSubsume WAG node, mirroring what DestroyReplica does with EventDestroy. A test mirroring TestDestroyReplica is added. The snapshot application path doesn't have things wired up yet, so that's left for a future patch. Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
arulajmani
force-pushed
the
rse-subsume-wag-event
branch
from
a18afa3 to
6f17bcb
Compare
Collaborator
Author
|
I ended up squashing the two commits to get around the broken test issue. TFTR! |
Collaborator
|
nag: link to the issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestDestroyReplicato make them reusable.TestSubsumeReplicausing the shared helpers.SubsumeReplicato write anEventSubsumeWAG node, mirroringDestroyReplica'sEventDestroy. The snapshot application path doesn'thave things wired up yet, so that's left for a future patch.
Part of #165186