Skip to content

release-24.3: roachtest: add async association tests to activerecord ignore list#168341

Merged
trunk-io[bot] merged 1 commit intocockroachdb:release-24.3from
spilchen:blathers/backport-release-24.3-168318
Apr 14, 2026
Merged

release-24.3: roachtest: add async association tests to activerecord ignore list#168341
trunk-io[bot] merged 1 commit intocockroachdb:release-24.3from
spilchen:blathers/backport-release-24.3-168318

Conversation

@spilchen
Copy link
Copy Markdown
Contributor

@spilchen spilchen commented Apr 14, 2026

Backport 1/1 commits from #168318 on behalf of @spilchen.


The AsyncBelongsToAssociationsTest, AsyncHasManyAssociationsTest, and AsyncHasOneAssociationsTest tests all use a wait_for_async_query helper with a 5-second timeout that flakes on CI when CockroachDB query execution exceeds the deadline. These are the same class of flake as the five LoadAsyncTest entries already on the ignore list (added in d5431d9 for #162147), but the association test variants were missed at that time.

Closes: #164804
Epic: none

Release note: None


Release justification: test only fix

The `AsyncBelongsToAssociationsTest`, `AsyncHasManyAssociationsTest`, and
`AsyncHasOneAssociationsTest` tests all use a `wait_for_async_query`
helper with a 5-second timeout that flakes on CI when CockroachDB query
execution exceeds the deadline. These are the same class of flake as
the five `LoadAsyncTest` entries already on the ignore list (added in
d5431d9 for cockroachdb#162147), but the association test variants were missed
at that time.

Closes: cockroachdb#164804
Epic: none

Release note: None

Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Apr 14, 2026
@blathers-crl blathers-crl bot requested a review from bghal April 14, 2026 17:46
@trunk-io
Copy link
Copy Markdown
Contributor

trunk-io bot commented Apr 14, 2026

😎 Merged directly without going through the merge queue, as the queue was empty and the PR was up to date with the target branch - details.

@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Apr 14, 2026

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes OR fixes for serious issues. Non-production includes test-only changes, build system changes, etc. Serious issues are defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to. Reference the approved ENGREQ ticket in the PR body (e.g., "Fixes ENGREQ-123").

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl bot added backport Label PR's that are backports to older release branches T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Apr 14, 2026
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@blathers-crl blathers-crl bot added the backport-test-only Used to denote the backport has only non-production changes label Apr 14, 2026
@spilchen
Copy link
Copy Markdown
Contributor Author

/trunk merge

@trunk-io trunk-io bot merged commit 6dac390 into cockroachdb:release-24.3 Apr 14, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches backport-test-only Used to denote the backport has only non-production changes blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) target-release-24.3.32

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants