release-26.2.0-rc: release-26.2: sql/importer: disable INSPECT after IMPORT validation by default#168424
Merged
celiala merged 1 commit intocockroachdb:release-26.2.0-rcfrom Apr 16, 2026
Conversation
IMPORT row count validation has been failing on drt-chaos-aws with multiple distinct failure modes (off-by-one, 2x doubling, deficit) despite prior fixes (cockroachdb#165697, cockroachdb#168158). This is suspected to be an accounting problem and not actual data corruption. Change the default value of `bulkio.import.row_count_validation.mode` from `async` to `off` to prevent spurious INSPECT errors from surfacing in customer environments. The setting remains user-configurable and can be re-enabled once the root cause of cockroachdb#168396 is identified and fixed. Metamorphic test builds continue to randomly exercise all three modes (off, async, sync). Fixes: cockroachdb#168400 Epic: none Release note: none Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
blathers-crl
bot
added
blathers-backport
|
Thanks for opening a backport. Before merging, please confirm that the change does not break backwards compatibility and otherwise complies with the backport policy. Include a brief release justification in the PR description explaining why the backport is appropriate. All backports must be reviewed by the TL for the owning area. While the stricter LTS policy does not yet apply, please exercise judgment and consider gating non-critical changes behind a disabled-by-default feature flag when appropriate. |
blathers-crl
bot
added
backport
Member
|
This change is |
fqazi
approved these changes
Apr 16, 2026
Collaborator
fqazi
left a comment
fqazi
left a comment
There was a problem hiding this comment.
@fqazi reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on bghal, DrewKimball, and rafiss).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #168403 on behalf of @spilchen.
IMPORT row count validation has been failing on drt-chaos-aws with multiple distinct failure modes (off-by-one, 2x doubling, deficit) despite prior fixes (#165697, #168158). This is suspected to be an accounting problem and not actual data corruption.
Change the default value of
bulkio.import.row_count_validation.modefromasynctooffto prevent spurious INSPECT errors from surfacing in customer environments. The setting remains user-configurable and can be re-enabled once the root cause of #168396 is identified and fixed.Metamorphic test builds continue to randomly exercise all three modes (off, async, sync).
Fixes: #168400
Epic: none
Release note: none
Release justification: see https://cockroachlabs.atlassian.net/servicedesk/customer/portal/138/ENGREQ-415