logictest: filter cluster_locks queries in select_for_share to test database#168751
Merged
trunk-io[bot] merged 1 commit intocockroachdb:masterfrom May 6, 2026
Merged
Conversation
…atabase With virtual intent resolution (VIR) enabled metamorphically, bootstrap intents on system.role_members can persist in the lock table and appear in unfiltered crdb_internal.cluster_locks queries, causing the test to see unexpected rows. Fixes cockroachdb#168339 Release note: None Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
Contributor
|
😎 Merged successfully - details. |
Member
|
This change is |
rafiss
approved these changes
May 6, 2026
Collaborator
rafiss
left a comment
rafiss
left a comment
There was a problem hiding this comment.
thanks for the fix! I'll go ahead and merge since this deflakes the test
/trunk merge
|
Detected infrastructure failure on trunk-merge branch (matched: self-hosted runner lost communication with the server). Automatically resubmitting to merge queue (attempt 1 of 2). (run link) |
|
/trunk merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With virtual intent resolution (VIR) enabled metamorphically, bootstrap
intents on system.role_members can persist in the lock table and appear
in unfiltered crdb_internal.cluster_locks queries, causing the test to
see unexpected rows.
Fixes #168339
Epic: none
Release note: None