sql/opt: treat privilege errors as stale memos during dependency checks#169190
Conversation
Previously, when the query cache's `CheckDependencies` re-resolved data sources from a cached memo and encountered a privilege error (e.g. because the memo referenced objects in a different database context), the error was propagated to the user. This caused unqualified function calls to fail with USAGE privilege errors referencing schemas from the wrong database when two databases had identically-named functions in custom schemas. Now, `maybeSwallowMetadataResolveErr` also swallows `pgcode.InsufficientPrivilege` errors, treating them as indicators that the memo is stale. The memo is evicted and replanned in the correct user/database context, where genuine privilege errors will surface during planning. Fixes: cockroachdb#168992 Release note (bug fix): Fixed a bug where unqualified function calls could fail with incorrect privilege errors when two databases on the same cluster had identically-named functions in custom schemas. The query cache could serve a memo from one database context to another, causing USAGE privilege errors referencing schemas from the wrong database. Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
|
😎 Merged successfully - details. |
|
This change is |
michae2
added
backport-25.2.x
|
How do we feel about backporting this without a session var or cluster setting? |
DrewKimball
left a comment
DrewKimball
left a comment
There was a problem hiding this comment.
@DrewKimball reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on mw5h and rafiss).
|
TFTR! /trunk merge |
|
Detected infrastructure failure on trunk-merge branch (matched: self-hosted runner lost communication with the server). Automatically resubmitting to merge queue (attempt 1 of 2). (run link) |
|
/trunk merge |
|
Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches. Issue #168992: branch-release-25.2.18-rc, branch-release-25.4, branch-release-26.1, branch-release-26.2. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating backport branch refs/heads/blathers/backport-release-25.2-169190: POST https://api.github.com/repos/michae2/cockroach/git/refs: 403 Resource not accessible by integration [] Backport to branch 25.2.x failed. See errors above. error creating backport branch refs/heads/blathers/backport-release-25.4-169190: POST https://api.github.com/repos/michae2/cockroach/git/refs: 403 Resource not accessible by integration [] Backport to branch 25.4.x failed. See errors above. error creating backport branch refs/heads/blathers/backport-release-26.1-169190: POST https://api.github.com/repos/michae2/cockroach/git/refs: 403 Resource not accessible by integration [] Backport to branch 26.1.x failed. See errors above. error creating backport branch refs/heads/blathers/backport-release-26.2-169190: POST https://api.github.com/repos/michae2/cockroach/git/refs: 403 Resource not accessible by integration [] Backport to branch 26.2.x failed. See errors above. error creating backport branch refs/heads/blathers/backport-release-25.2.18-rc-169190: POST https://api.github.com/repos/michae2/cockroach/git/refs: 403 Resource not accessible by integration [] Backport to branch 25.2.18-rc failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
3 participants
Previously, when the query cache's
CheckDependenciesre-resolved data sources from a cached memo and encountered a privilege error (e.g. because the memo referenced objects in a different database context), the error was propagated to the user. This caused unqualified function calls to fail with USAGE privilege errors referencing schemas from the wrong database when two databases had identically-named functions in custom schemas.Now,
maybeSwallowMetadataResolveErralso swallowspgcode.InsufficientPrivilegeerrors, treating them as indicators that the memo is stale. The memo is evicted and replanned in the correct user/database context, where genuine privilege errors will surface during planning.Fixes: #168992
Release note (bug fix): Fixed a bug where unqualified function calls could fail with incorrect privilege errors when two databases on the same cluster had identically-named functions in custom schemas. The query cache could serve a memo from one database context to another, causing USAGE privilege errors referencing schemas from the wrong database.