opt: implement PlanGram parser#169197
Open
michae2 wants to merge 1 commit intocockroachdb:masterfrom
Open
Conversation
Contributor
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Member
|
This change is |
michae2
force-pushed
the
plangram-parse
branch
5 times, most recently
from
6c53995 to
96c1406
Compare
Collaborator
Author
|
This parser is based on the one in master...michae2:cockroach:pheromone but with some cleanup from Claude. Being able to parse plangrams makes testcases simpler, and will come in handy if one day we want to use them directly. |
DrewKimball
approved these changes
May 5, 2026
Collaborator
DrewKimball
left a comment
DrewKimball
left a comment
There was a problem hiding this comment.
@DrewKimball reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on ZhouXing19).
Implement ParsePlanGram, a recursive-descent parser with 1-token lookahead for plangram grammars. The parser reads from an io.Reader using bufio.Scanner with a custom SplitFunc. A reverse-lookup function OperatorByCamelCase is added to the optgen code generator to map camel-case operator names (e.g. "InnerJoin") back to opt.Operator values during parsing. Informs: cockroachdb#152053 Release note: None Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement ParsePlanGram, a recursive-descent parser with 1-token lookahead for plangram grammars. The parser reads from an io.Reader using bufio.Scanner with a custom SplitFunc.
A reverse-lookup function OperatorByCamelCase is added to the optgen code generator to map camel-case operator names (e.g. "InnerJoin") back to opt.Operator values during parsing.
Informs: #152053
Release note: None
Co-Authored-By: roachdev-claude roachdev-claude-bot@cockroachlabs.com