changefeedccl: log g.Wait error in alter changefeed backfill test#169594
Draft
aerfrei wants to merge 1 commit intocockroachdb:masterfrom
Draft
changefeedccl: log g.Wait error in alter changefeed backfill test#169594aerfrei wants to merge 1 commit intocockroachdb:masterfrom
aerfrei wants to merge 1 commit intocockroachdb:masterfrom
Conversation
Contributor
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Member
|
This change is |
Surface the consumer goroutine's exit error rather than discarding it, to diagnose flakes where seenBarKeys is empty even though highwater advanced. This change logs any error other than "job canceled by user" which is expected when the test passes. Epic: none Release note: None Fixes: cockroachdb#169505
aerfrei
force-pushed
the
cdc-test-log-error
branch
from
519a824 to
91cb35a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surface the consumer goroutine's exit error rather than discarding it, to diagnose flakes where seenBarKeys is empty even though highwater advanced.
Epic: none
Release note: None