pkg/cli: map sys_uptime to sys.uptime.count in tsdump datadog upload#169738
Open
aa-joshi wants to merge 1 commit intocockroachdb:masterfrom
Open
pkg/cli: map sys_uptime to sys.uptime.count in tsdump datadog upload#169738aa-joshi wants to merge 1 commit intocockroachdb:masterfrom
aa-joshi wants to merge 1 commit intocockroachdb:masterfrom
Conversation
The sys.uptime metric is emitted with different names and types depending on the ingestion pipeline: - CRDB -> Datadog agent -> Datadog: emits sys.uptime.count as a count. - Cockroach Cloud CRDB -> OTel -> Datadog: emits sys.uptime as a gauge. - CRDB -> tsdump -> Datadog: emits sys.uptime as a count. Datadog expects a single metric type per metric name. When tsdump uploads sys.uptime as a count, it conflicts with the gauge variant from the OTel pipeline, causing inconsistent metric evaluation. The auto-generated Datadog metric mapping (cockroachdb_datadog_metrics.yaml) maps sys_uptime to sys.uptime, matching the Datadog integration's own naming. Since that file is generated at build time from the upstream Datadog integration source, the fix cannot go there. Instead, add a tsdump-specific name override that takes precedence over the generated mapping. This emits the metric as sys.uptime.count, giving a clear distinction between the counter and gauge variants. Long term we should standardize the metric type across all CRDB ingestion pipelines. Epic: None Release note: None
aa-joshi
requested review from
alyshanjahani-crl and
arjunmahishi
and removed request for
a team
Contributor
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Member
|
This change is |
aa-joshi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sys.uptime metric is emitted with different names and types depending on the ingestion pipeline:
sys.uptime.countas a count.sys.uptimeas a gauge.sys.uptimeas a count.Datadog expects a single metric type per metric name. When tsdump uploads
sys.uptimeas a count, it conflicts with the gauge variant from the OTel pipeline, causing inconsistent metric evaluation.The auto-generated Datadog metric mapping (cockroachdb_datadog_metrics.yaml) maps
sys_uptimetosys.uptime, matching the Datadog integration's own naming. Since that file is generated at build time from the upstream Datadog integration source, the fix cannot go there.Instead, add a tsdump-specific name override that takes precedence over the generated mapping. This emits the metric as
sys.uptime.count, giving a clear distinction between the counter and gauge variants. Long term we should standardize the metric type across all CRDB ingestion pipelines.Epic: None
Release note: None