mmaprototype: add captured_at to cluster state snapshot#169741
Merged
trunk-io[bot] merged 1 commit intocockroachdb:masterfrom May 5, 2026
Merged
mmaprototype: add captured_at to cluster state snapshot#169741trunk-io[bot] merged 1 commit intocockroachdb:masterfrom
trunk-io[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Add a top-level captured_at timestamp to ClusterStateSnapshot, populated from clusterState.ts (the same TimeSource MMA uses for its other timestamps). All time-typed fields in the snapshot (overload windows, last failed change, pending change start/gc/enacted-at) are absolute wall times, so consumers previously had to bring their own "now" to reason about whether a window is still active or how soon a change is about to be GC'd. Carrying the capture time alongside the rest of the state removes that ambiguity at negligible size cost. Epic: none Release note: None Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
Contributor
|
😎 Merged successfully - details. |
Member
|
This change is |
Member
Author
|
@wenyihu6 this is your commit from the other PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a top-level
captured_attimestamp toClusterStateSnapshot, populated fromclusterState.ts(the sameTimeSourceMMA uses for its other timestamps). All time-typed fields in the snapshot (overload windows, last failed change, pending change start/gc/enacted-at) are absolute wall times, so consumers previously had to bring their own "now" to reason about whether a window is still active or how soon a change is about to be GC'd. Carrying the capture time alongside the rest of the state removes that ambiguity at negligible size cost.Epic: none
Release note: None