roachtest: widen disk-bandwidth-limiter lower-bound threshold#169748
Merged
trunk-io[bot] merged 1 commit intocockroachdb:masterfrom May 5, 2026
Merged
Conversation
The lower-bound threshold for mean total bandwidth was too tight at 20% (51.2 MiB/s), causing flaky failures across multiple platforms (GCE amd64, GCE ARM64, IBM s390x) when bandwidth dipped marginally below the threshold. Widen the margin from 20% to 30% (44.8 MiB/s), matching the upper-bound margin. The limiter is working correctly in all observed failures; the test was just too sensitive to normal I/O variability. Fixes: cockroachdb#169721 Epic: none Release note: None Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
Contributor
|
😎 Merged successfully - details. |
Member
|
This change is |
angeladietz
added
the
backport-26.2.x
tbg
approved these changes
May 5, 2026
|
Detected infrastructure failure (matched: self-hosted runner lost communication with the server). Automatically rerunning failed jobs. (run link) |
Contributor
Author
|
/trunk merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lower-bound threshold for mean total bandwidth was too tight at 20%
(51.2 MiB/s), causing flaky failures across multiple platforms (GCE
amd64, GCE ARM64, IBM s390x) when bandwidth dipped marginally below the
threshold. Widen the margin from 20% to 30% (44.8 MiB/s), matching the
upper-bound margin. The limiter is working correctly in all observed
failures; the test was just too sensitive to normal I/O variability.
Fixes: #169721
Epic: none
Release note: None